You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/08 18:10:40 UTC
[jira] [Commented] (THRIFT-3719) Dart generator should use
lowerCamelCase for service names
[ https://issues.apache.org/jira/browse/THRIFT-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185268#comment-15185268 ]
ASF GitHub Bot commented on THRIFT-3719:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/932
THRIFT-3719 Generate Dart service methods as lowerCamelCase
This matches the Dart Style Guide and is consistent with struct generation.
@stevenosborne-wf @tylertreat-wf
https://issues.apache.org/jira/browse/THRIFT-3719
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/932.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #932
----
commit 806f7659bc7cfd4843b6c5297e0fc0d078713072
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-03-08T17:06:23Z
Generate Dart service methods as lowerCamelCase
This matches the Dart Style Guide and is consistent with struct generation.
https://issues.apache.org/jira/browse/THRIFT-3719
----
> Dart generator should use lowerCamelCase for service names
> ----------------------------------------------------------
>
> Key: THRIFT-3719
> URL: https://issues.apache.org/jira/browse/THRIFT-3719
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Compiler
> Reporter: Mark Erickson
> Assignee: Mark Erickson
> Fix For: 0.10.0
>
>
> In order to match the Dart style guide, class members should be lowerCamelCase. This would also be more consistent with how Dart produces names for struct fields. However, the name in TMessage should stay the same to ensure no adverse impact on server communication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)