You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/13 18:55:00 UTC

Review Request 15486: [HELIX-304] Add rat check to hpost-review, add missing license header

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15486/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-304


Repository: helix-git


Description
-------

commit f3dd63312d75910e78821fbe3054b4c4150992c0
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Wed Nov 13 09:43:37 2013 -0800

    [HELIX-304] Add rat check to hpost-review, add missing license header

:100644 100644 ede570a... 489369e... M	helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java
:100755 100755 0f1f5a1... 7ccc41c... M	hpost-review.sh


Diffs
-----

  helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java ede570a 
  hpost-review.sh 0f1f5a1 

Diff: https://reviews.apache.org/r/15486/diff/


Testing
-------

Tried this script on this review with and without the missing header, seems to work correctly.


Thanks,

Kanak Biscuitwala


Re: Review Request 15486: [HELIX-304] Add rat check to hpost-review, add missing license header

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15486/#review28816
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On Nov. 13, 2013, 5:54 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15486/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 5:54 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-304
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit f3dd63312d75910e78821fbe3054b4c4150992c0
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Wed Nov 13 09:43:37 2013 -0800
> 
>     [HELIX-304] Add rat check to hpost-review, add missing license header
> 
> :100644 100644 ede570a... 489369e... M	helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java
> :100755 100755 0f1f5a1... 7ccc41c... M	hpost-review.sh
> 
> 
> Diffs
> -----
> 
>   helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java ede570a 
>   hpost-review.sh 0f1f5a1 
> 
> Diff: https://reviews.apache.org/r/15486/diff/
> 
> 
> Testing
> -------
> 
> Tried this script on this review with and without the missing header, seems to work correctly.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>