You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yongqiao Wang <yq...@cn.ibm.com> on 2016/01/25 16:00:43 UTC
Review Request 42719: Add doc for weights.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs
-----
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > Looks good, but I think we can pull this information into the roles.md and endpoint help docs, rather than create a new docs page.
Maybe weight will also be supported for framework in the future, so I think it is better to create a new doc for weights.
> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > docs/weights.md, line 5
> > <https://reviews.apache.org/r/42719/diff/1/?file=1219343#file1219343line5>
> >
> > Why not just include this in the existing roles.md?
> > If you are creating a new doc, you ought to add it to home.md so it can easily be found and navigated to.
I considered that weight will also be support for framework, so I created a new doc for that.
> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > docs/weights.md, line 19
> > <https://reviews.apache.org/r/42719/diff/1/?file=1219343#file1219343line19>
> >
> > I wonder if all this information should just go in the endpoint help description, and then you can link to it in the new auto-generated endpoints docs, e.g. http://mesos.apache.org/documentation/latest/endpoints/master/roles/
The /weights endpoint help description will be auto-generated from strings stored in the Mesos source code, so if we still decide to create a new doc for weights, then does not need to add this link.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review118617
-----------------------------------------------------------
On Jan. 25, 2016, 3 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 3 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review118617
-----------------------------------------------------------
Looks good, but I think we can pull this information into the roles.md and endpoint help docs, rather than create a new docs page.
docs/weights.md (line 5)
<https://reviews.apache.org/r/42719/#comment179904>
Why not just include this in the existing roles.md?
If you are creating a new doc, you ought to add it to home.md so it can easily be found and navigated to.
docs/weights.md (line 9)
<https://reviews.apache.org/r/42719/#comment179905>
s/0.26/0.27/
s/specify/specifying/
docs/weights.md (line 10)
<https://reviews.apache.org/r/42719/#comment179906>
s/, if/. If/
docs/weights.md (line 11)
<https://reviews.apache.org/r/42719/#comment179907>
"If a role does not have a weight specified in the --weights flag, ..."
docs/weights.md (lines 12 - 13)
<https://reviews.apache.org/r/42719/#comment179908>
Weights cannot be changed without updating the flag and restarting all Mesos masters.
docs/weights.md (line 15)
<https://reviews.apache.org/r/42719/#comment179909>
s/0.27/0.28/
s/involved, and .../introduced so an operator can update weights at runtime./
docs/weights.md (line 19)
<https://reviews.apache.org/r/42719/#comment179911>
I wonder if all this information should just go in the endpoint help description, and then you can link to it in the new auto-generated endpoints docs, e.g. http://mesos.apache.org/documentation/latest/endpoints/master/roles/
docs/weights.md (line 55)
<https://reviews.apache.org/r/42719/#comment179910>
s/include//
- Adam B
On Jan. 25, 2016, 7 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 7 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review122507
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 8, 2016, 11:27 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 11:27 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 4327d461f3bd4cced85ceb505414b3e1afefff17
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
(Updated March 8, 2016, 11:27 a.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs (updated)
-----
docs/home.md 4327d461f3bd4cced85ceb505414b3e1afefff17
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review122298
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 7, 2016, 11:35 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 11:35 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On March 8, 2016, 9:19 a.m., Adam B wrote:
> > docs/weights.md, lines 22-23
> > <https://reviews.apache.org/r/42719/diff/5/?file=1282836#file1282836line22>
> >
> > This will have to be updated when we add GET
I will update this doc for GET request after addressing #MESOS-4316.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review122488
-----------------------------------------------------------
On March 8, 2016, 11:27 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 11:27 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 4327d461f3bd4cced85ceb505414b3e1afefff17
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review122488
-----------------------------------------------------------
Fix it, then Ship it!
docs/weights.md (lines 51 - 53)
<https://reviews.apache.org/r/42719/#comment184516>
"Weights are now persisted in the registry on cluster bootstrap and after any updates. Once the weights are persisted in the registry, any Mesos master that subsequently starts with `--weights` still specified will warn and use the registry value instead."
docs/weights.md (lines 22 - 23)
<https://reviews.apache.org/r/42719/#comment184517>
This will have to be updated when we add GET
- Adam B
On March 7, 2016, 3:35 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 3:35 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
(Updated March 7, 2016, 11:35 a.m.)
Review request for mesos and Adam B.
Changes
-------
Updated the released version of dynamic weights to 0.29.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs (updated)
-----
docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121426
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 1, 2016, 7:53 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 7:53 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
(Updated March 1, 2016, 7:53 a.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs (updated)
-----
docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review119871
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:56 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 07214b927c112d7a180507ae03245892455fd757
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On Feb. 28, 2016, 8:21 a.m., Adam B wrote:
> > Thanks! Couple of tweaks as I review it again.
> > - How did you test that this renders correctly? Did you try `support/site-docker` to see if the markdown translates properly to html? Just because it looks good in github doesn't mean our Rakefile will make it look as good.
Yes, I have tried `support/site-docker`. This new doc looks good.
> On Feb. 28, 2016, 8:21 a.m., Adam B wrote:
> > docs/weights.md, line 16
> > <https://reviews.apache.org/r/42719/diff/3/?file=1259048#file1259048line16>
> >
> > Are we officially deprecating --weights in this release? If so, we'll need to update upgrades.md and the CHANGELOG to mention this.
> >
> > Could you also document what happens when a master restarts with a --weights flag that differs from what's in the registry? (We warn and use the registry value, correct?)
`--weights` does not deprecate in this release (0.28), for backwark compitibility, it will be deprecated in a future release (Maybe six months later).
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
-----------------------------------------------------------
On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:56 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 07214b927c112d7a180507ae03245892455fd757
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
-----------------------------------------------------------
Thanks! Couple of tweaks as I review it again.
- How did you test that this renders correctly? Did you try `support/site-docker` to see if the markdown translates properly to html? Just because it looks good in github doesn't mean our Rakefile will make it look as good.
docs/weights.md (line 7)
<https://reviews.apache.org/r/42719/#comment182768>
"... priority among roles." - and link to roles.md.
docs/weights.md (line 9)
<https://reviews.apache.org/r/42719/#comment182769>
s/via/by/
docs/weights.md (line 16)
<https://reviews.apache.org/r/42719/#comment182773>
Are we officially deprecating --weights in this release? If so, we'll need to update upgrades.md and the CHANGELOG to mention this.
Could you also document what happens when a master restarts with a --weights flag that differs from what's in the registry? (We warn and use the registry value, correct?)
docs/weights.md (line 32)
<https://reviews.apache.org/r/42719/#comment182770>
s/example/example,/
docs/weights.md (line 48)
<https://reviews.apache.org/r/42719/#comment182771>
s/the specified/all specified/
docs/weights.md (line 54)
<https://reviews.apache.org/r/42719/#comment182772>
s/negative/non-positive/ (since 0 is also invalid)
- Adam B
On Feb. 18, 2016, 11:56 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 11:56 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md 07214b927c112d7a180507ae03245892455fd757
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 7:56 a.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed comments of Adam.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs (updated)
-----
docs/home.md 07214b927c112d7a180507ae03245892455fd757
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review119829
-----------------------------------------------------------
Fix it, then Ship it!
Thanks! (Sorry for the delay)
docs/weights.md (line 21)
<https://reviews.apache.org/r/42719/#comment181180>
s/support/supports/
docs/weights.md (line 46)
<https://reviews.apache.org/r/42719/#comment181181>
s/with an implicit/with implicit/
docs/weights.md (line 54)
<https://reviews.apache.org/r/42719/#comment181182>
s/.,/./
- Adam B
On Feb. 14, 2016, 4:47 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2016, 4:47 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review119184
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 14, 2016, 12:47 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2016, 12:47 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 42719: Add doc for weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/
-----------------------------------------------------------
(Updated Feb. 14, 2016, 12:47 p.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed the comments of Adam.
Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945
Repository: mesos
Description
-------
Add doc for weights.
Diffs (updated)
-----
docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88
docs/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
-------
Thanks,
Yongqiao Wang
Re: Review Request 42719: Add doc for weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review116114
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42719]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 25, 2016, 3 p.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 3 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add doc for weights.
>
>
> Diffs
> -----
>
> docs/weights.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42719/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yongqiao Wang
>
>