You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2023/01/07 02:34:22 UTC

[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2842: fix java syntax errors

jonyangx commented on code in PR #2842:
URL: https://github.com/apache/incubator-eventmesh/pull/2842#discussion_r1063940568


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteUnSubscribeEventProcessor.java:
##########
@@ -104,11 +104,14 @@ public void handler(HandlerService.HandlerSpecific handlerSpecific, HttpRequest
 
         //validate body
         byte[] requestBody = requestWrapper.getBody();
-
-        Map<String, Object> requestBodyMap = Optional.ofNullable(JsonUtils.deserialize(
-            new String(requestBody, Constants.DEFAULT_CHARSET),
-            new TypeReference<HashMap<String, Object>>() {}
-        )).orElseGet(Maps::newHashMap);
+        Map<String, Object> requestBodyMap;

Review Comment:
   The code is redundant than before. @chenyi19851209 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org