You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2014/02/24 20:39:19 UTC
[jira] [Commented] (LUCENE-5469) Add small rounding to
FuzzyQuery.floatToEdits
[ https://issues.apache.org/jira/browse/LUCENE-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910716#comment-13910716 ]
Robert Muir commented on LUCENE-5469:
-------------------------------------
I'm not really sure this is a bug. This is the way this crazy percentage always worked (a minimum bound, not inclusive!), and we just preserved that. I think instead we should remove this deprecated syntax from trunk completely?
> Add small rounding to FuzzyQuery.floatToEdits
> ---------------------------------------------
>
> Key: LUCENE-5469
> URL: https://issues.apache.org/jira/browse/LUCENE-5469
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Affects Versions: 5.0
> Reporter: Tim Allison
> Priority: Trivial
> Labels: easyfix
> Attachments: LUCENE-5469.patch
>
>
> I realize that FuzzyQuery.floatToEdits is deprecated, but I'd like to make a small fix for posterity. Because of floating point issues, if a percentage leads to a number that is very close to a whole number of edits, our cast to int can improperly cause misses.
> ddddd~0.8 will not match "ddddX"
> eeeee~0.8 will not match "eeee" or "eeeeee"
> This is a trivial part of the plan to reduce code duplication with LUCENE-5205.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org