You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2018/06/19 02:39:52 UTC

[GitHub] incubator-weex pull request #1275: [WEEX-342][android] when animation module...

GitHub user gubaojian opened a pull request:

    https://github.com/apache/incubator-weex/pull/1275

    [WEEX-342][android] when animation module or transition parser properties, some propers may be not right, so add try catch to handle the exceptions

    [WEEX-342][android] when animation module or transition parser properties, some propers may be not right, so add try catch to handle the exceptions

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gubaojian/incubator-weex release-0.19-bugfix0619

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1275
    
----
commit 906a4fff878b4bc886957c6689df1fd90b59d7cb
Author: jianbai.gbj <ji...@...>
Date:   2018-06-19T02:38:33Z

    [WEEX-342][android] when animation module or transition parser properties, some propers may be not right, so add try catch to handle the exceptions

----


---

[GitHub] incubator-weex pull request #1275: [WEEX-342][android] when animation module...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1275


---

[GitHub] incubator-weex issue #1275: [WEEX-342][android] when animation module or tra...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1275
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., Potential BREAK C...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---