You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/05 23:00:03 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3003:
ARTEMIS-2645 refactor CLI FQQN support
jbertram opened a new pull request #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003
FQQN support for the CLI was implemented via ARTEMIS-1840 before general
FQQN support was added for producers via ARTEMIS-1867. The CLI's FQQN
functionality is slightly different from what is now generally available
and it can be confusing for users. By refactoring the CLI to use the
general FQQN support the code can be much simpler and consistent with
the expected behavior. Refactoring includes:
- Deprecating the use of "fqqn://". The CLI commands use JMS so using
"fqqn://" (instead of "queue://" or "topic://") makes the destination
type ambiguous which can yield unexpected message routing behavior.
Now "queue://" and "topic://" can be used with the normal FQQN syntax
(e.g. address::queue).
- Eliminating the use of the _AMQ_ROUTE_TO header when sending messags
to an FQQN. The _AMQ_ROUTE_TO header is an internal header used when
routing messages over a cluster bridge. Using it in the CLI for FQQN
support was a clever hack, but using the general FQQN support
eliminates complexity and makes behavior consistent between
standalone JMS clients using FQQN and the CLI.
- De-duplicating MessageSerializer initialization boilerplate.
- Removing limitation where using an FQQN with an anycast address
required the same name for the address and queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3003:
ARTEMIS-2645 refactor CLI FQQN support
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003#issuecomment-596142639
@jbertram I'm getting test failures
Failed tests:
MessageSerializerTest.testTextMessageImportExport:177->checkSentMessages:104->CliTestBase.consumeMessages:147 null
Tests in error:
MessageSerializerTest.testMapMessageImportExport:227 » InvalidDestination AMQ2...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3003: ARTEMIS-2645 refactor CLI FQQN support
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003#issuecomment-596142639
@jbertram I'm getting test failures in the CLI test cases
Failed tests:
MessageSerializerTest.testTextMessageImportExport:177->checkSentMessages:104->CliTestBase.consumeMessages:147 null
Tests in error:
MessageSerializerTest.testMapMessageImportExport:227 » InvalidDestination AMQ2...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #3003: ARTEMIS-2645
refactor CLI FQQN support
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003#issuecomment-596565965
@michaelandrepearce, there must be a race condition somewhere. When I run those tests I don't get any failures. I'll continue investigating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3003: ARTEMIS-2645
refactor CLI FQQN support
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #3003: ARTEMIS-2645
refactor CLI FQQN support
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #3003: ARTEMIS-2645 refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003#issuecomment-596769024
@michaelandrepearce I was able to reproduce the failures and I've sent #3009 to address them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services