You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/15 10:53:35 UTC
Review Request 57637: Few breadcrumbs are missing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57637/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20456
https://issues.apache.org/jira/browse/ambari-20456
Repository: ambari
Description
-------
* admin/stack/versions
* admin/stack/history
* some views
Add ability to generate breadcrumbs from Routes if they are not set manually
Diffs
-----
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a760f0c
ambari-web/app/routes/activate_hawq_standby_routes.js 9ba6073
ambari-web/app/routes/add_hawq_standby_routes.js 346f506
ambari-web/app/routes/add_kerberos_routes.js 462ce44
ambari-web/app/routes/high_availability_routes.js 8f5fb13
ambari-web/app/routes/main.js aace4a2
ambari-web/app/routes/manage_journalnode_routes.js 90b45b0
ambari-web/app/routes/ra_high_availability_routes.js 5be6c44
ambari-web/app/routes/reassign_master_routes.js 341172b
ambari-web/app/routes/remove_hawq_standby_routes.js 64250ee
ambari-web/app/routes/rm_high_availability_routes.js d8aa8b3
ambari-web/app/routes/stack_upgrade_routes.js f95dd6e
ambari-web/app/routes/view.js 22a4057
ambari-web/app/routes/views.js 073507c
ambari-web/app/views/common/breadcrumbs_view.js f9073ba
ambari-web/test/views/common/breadcrumbs_view_test.js 751811c
Diff: https://reviews.apache.org/r/57637/diff/1/
Testing
-------
20578 passing (21s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57637: Few breadcrumbs are missing
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57637/#review168987
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On March 15, 2017, 10:53 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57637/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 10:53 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20456
> https://issues.apache.org/jira/browse/ambari-20456
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * admin/stack/versions
> * admin/stack/history
> * some views
>
> Add ability to generate breadcrumbs from Routes if they are not set manually
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a760f0c
> ambari-web/app/routes/activate_hawq_standby_routes.js 9ba6073
> ambari-web/app/routes/add_hawq_standby_routes.js 346f506
> ambari-web/app/routes/add_kerberos_routes.js 462ce44
> ambari-web/app/routes/high_availability_routes.js 8f5fb13
> ambari-web/app/routes/main.js aace4a2
> ambari-web/app/routes/manage_journalnode_routes.js 90b45b0
> ambari-web/app/routes/ra_high_availability_routes.js 5be6c44
> ambari-web/app/routes/reassign_master_routes.js 341172b
> ambari-web/app/routes/remove_hawq_standby_routes.js 64250ee
> ambari-web/app/routes/rm_high_availability_routes.js d8aa8b3
> ambari-web/app/routes/stack_upgrade_routes.js f95dd6e
> ambari-web/app/routes/view.js 22a4057
> ambari-web/app/routes/views.js 073507c
> ambari-web/app/views/common/breadcrumbs_view.js f9073ba
> ambari-web/test/views/common/breadcrumbs_view_test.js 751811c
>
>
> Diff: https://reviews.apache.org/r/57637/diff/1/
>
>
> Testing
> -------
>
> 20578 passing (21s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>