[GitHub] seanyinx commented on a change in pull request #113: SCB-211 wait until connection recover instead of try sending

[GitBox <gi...@apache.org>]

seanyinx commented on a change in pull request #113: SCB-211 wait until connection recover instead of try sending
URL: https://github.com/apache/incubator-servicecomb-saga/pull/113#discussion_r161398191
 
 

 ##########
 File path: omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSender.java
 ##########
 @@ -50,6 +52,10 @@
   private final Map<MessageSender, Long> senders = new HashMap<>();
   private final Collection<ManagedChannel> channels;
 
+  private final ReentrantLock lock = new ReentrantLock();
+
+  private final Condition condition = lock.newCondition();
 
 Review comment:
   locks are hard to reason and easy to problems. not recommended to use them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services