[jira] [Comment Edited] (HIVE-22317) Beeline-site parser does not handle the variable substitution correctly

["mahesh kumar behera (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978109#comment-16978109 ] 

mahesh kumar behera edited comment on HIVE-22317 at 11/20/19 6:44 AM:
----------------------------------------------------------------------

[~Rajkumar Singh]

Code changes looks fine to me. Add a comment saying it is required for the variable config replacement case, as its not very intuitive to use conf.key when key.value is already present. Please add a test case also for the same.


was (Author: maheshk114):
[~Rajkumar Singh]

Code changes looks fine to me. Please add a test case also for the same.

> Beeline-site parser does not handle the variable substitution correctly
> -----------------------------------------------------------------------
>
>                 Key: HIVE-22317
>                 URL: https://issues.apache.org/jira/browse/HIVE-22317
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline
>    Affects Versions: 4.0.0
>         Environment: Hive-4.0.0
>            Reporter: Rajkumar Singh
>            Assignee: Rajkumar Singh
>            Priority: Major
>         Attachments: HIVE-22317.patch
>
>
> beeline-site.xml
> {code:java}
> <configuration xmlns:xi="http://www.w3.org/2001/XInclude">
>  
>  <property>
>  <name>beeline.hs2.jdbc.url.container</name>
>  <value>jdbc:hive2://c3220-node2.host.com:2181,c3220-node3.host.com:2181,c3220-node4.host.com:2181/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2</value>
>  </property>
>  
>  <property>
>  <name>beeline.hs2.jdbc.url.default</name>
>  <value>test</value>
>  </property>
>  <property>
> <name>beeline.hs2.jdbc.url.test</name>
> <value>${beeline.hs2.jdbc.url.container}?tez.queue.name=myqueue</value>
> </property> 
>  <property>
>  <name>beeline.hs2.jdbc.url.llap</name>
>  <value>jdbc:hive2://c3220-node2.host.com:2181,c3220-node3.host.com:2181,c3220-node4.host.com:2181/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2-interactive</value>
>  </property>
>  
>  </configuration>{code}
> beeline fail to connect because it does not parse the substituted value correctly
> {code:java}
> beeline
> Error in parsing jdbc url: ${beeline.hs2.jdbc.url.container}?tez.queue.name=myqueue from beeline-site.xml
> beeline>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)