You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/12/28 12:38:02 UTC

[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1445#discussion_r158937598
  
    --- Diff: build/docker/scripts/sca.sh ---
    @@ -56,7 +56,3 @@ echo  TODOs: `grep -r TODO * | wc -l`
     
     # LoC
     sloccount .
    -
    -# System Info
    --- End diff --
    
    Removing these lines looks unrelated to the task at hand, and they don't take much time, and they provide useful info.


---