[BUG?] force-response-1.0 broken?

[Martin Kraemer <Ma...@mch.sni.de>]

I have the impression that the current test for the "force-response-1.0"
variable is wrong: can someone please confirm this?

The test is something like
	 ... if (r->proto_num == HTTP_VERSION(1,0)
	     && table_get(r->subprocess_env, "force-response-1.0"))) { ...
But what sense does it make to downgrade a HTTP/1.0 request to HTTP/1.0?!?

OTOH, maybe the patch isn't correct either.

    Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Re: [BUG?] force-response-1.0 broken?

[Ben Laurie <be...@algroup.co.uk>]

Martin Kraemer wrote:
> 
> I have the impression that the current test for the "force-response-1.0"
> variable is wrong: can someone please confirm this?
> 
> The test is something like
>          ... if (r->proto_num == HTTP_VERSION(1,0)
>              && table_get(r->subprocess_env, "force-response-1.0"))) { ...
> But what sense does it make to downgrade a HTTP/1.0 request to HTTP/1.0?!?

We aren't downgrading the request - we are downgrading the response. The
code is correct as it stands.

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd,     |http://www.algroup.co.uk/Apache-SSL
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache