[jira] [Commented] (APEXMALHAR-2359) Optimise fire trigger to avoid go through all data

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709958#comment-15709958 ] 

ASF GitHub Bot commented on APEXMALHAR-2359:
--------------------------------------------

GitHub user brightchen opened a pull request:

    https://github.com/apache/apex-malhar/pull/518

    APEXMALHAR-2359 #resolve #comment Optimise fire trigger to avoid go t…

    …hrough all data

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brightchen/apex-malhar APEXMALHAR-2359

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #518
    
----
commit 665452248dfd437c176e5364665266839943c30b
Author: brightchen <br...@datatorrent.com>
Date:   2016-11-29T23:05:09Z

    APEXMALHAR-2359 #resolve #comment Optimise fire trigger to avoid go through all data

----


> Optimise fire trigger to avoid go through all data
> --------------------------------------------------
>
>                 Key: APEXMALHAR-2359
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2359
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: bright chen
>            Assignee: bright chen
>   Original Estimate: 144h
>  Remaining Estimate: 144h
>
> KeyedWindowedOperatorImpl.fireNormalTrigger(Window, boolean) currently go through each window and key to check value. The data collection could be very huge as the discard period could be relative long time. If fireOnlyUpdatedPanes is false probably there don't have much space to improve. But if fireOnlyUpdatedPanes is true, we don't have to go through the whole data collection. We only need to go through the window and key which handle after last trigger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)