[GitHub] [beam] haraldrombaut commented on a change in pull request #14294: [BEAM-12007] Set message ordering key for Google Pubsub

[GitBox <gi...@apache.org>]

haraldrombaut commented on a change in pull request #14294:
URL: https://github.com/apache/beam/pull/14294#discussion_r599528698



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
##########
@@ -1093,14 +1090,7 @@ public void processElement(ProcessContext c) throws IOException, SizeLimitExceed
         }
 
         // NOTE: The record id is always null.
-        output.add(
-            OutgoingMessage.of(
-                com.google.pubsub.v1.PubsubMessage.newBuilder()
-                    .setData(ByteString.copyFrom(payload))
-                    .putAllAttributes(attributes)
-                    .build(),
-                c.timestamp().getMillis(),
-                null));
+        output.add(OutgoingMessage.of(message, c.timestamp().getMillis(), null));

Review comment:
       The unbounded sink already uses this static method, where the com.google.pubsub.v1.PubsubMessage is being created from the PubsubIO PubsubMessage




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org