[GitHub] [incubator-druid] sashidhar edited a comment on issue #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

[GitBox <gi...@apache.org>]

sashidhar edited a comment on issue #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()
URL: https://github.com/apache/incubator-druid/pull/7764#issuecomment-496387005
 
 
   @gianm , @leventov 
   This is the failure. Can you help me understand this recommendation.
   ```
   Selected: Structural Search Inspection (1)
   indexing-service/src/main/java/org/apache/druid/indexing/overlord
   ForkingTaskRunner.java (1)
   217:  A ConcurrentHashMap on which computeIfAbsent() is called should be assigned into variables of ConcurrentHashMap type, not ConcurrentMap
   ```
   This is the line. Why should ConcurrentMap changed to ConcurrentHashMap type here ?
   private final ConcurrentMap<String, ForkingTaskRunnerWorkItem> tasks = new ConcurrentHashMap<>();
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org