You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/06/25 18:36:59 UTC
[GitHub] [submarine-site] jiwq opened a new pull request #16: SUBMARINE-546. Update Submarine Website for 0.4.0 release
jiwq opened a new pull request #16:
URL: https://github.com/apache/submarine-site/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine-site] wangdatan commented on a change in pull request #16: SUBMARINE-546. Update Submarine Website for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
wangdatan commented on a change in pull request #16:
URL: https://github.com/apache/submarine-site/pull/16#discussion_r445883044
##########
File path: _includes/themes/submarine/_navigation.html
##########
@@ -24,34 +25,27 @@
</ul>
</li>
-
<!-- Download -->
<li><a href="/download.html">Download</a></li>
<!-- Docs -->
- <!--li class="docs">
- <a href="#" data-toggle="dropdown" class="dropdown-toggle">Docs<b class="caret"></b></a>
- <ul class="dropdown-menu">
- <li class="title"><span><b>Release</b><span></li>
- <li><a href="https://hadoop.apache.org/submarine/docs/0.2.0/Index/">0.2.0</a></li>
- <li><a href="http://hadoop.apache.org/submarine/docs/">0.1.0</a></li>
- <li role="separator" class="divider"></li>
- <li class="title"><span><b>Snapshot (development)</b><span></li>
- <li><a href="/docs/0.3.0-SNAPSHOT">0.3.0-SNAPSHOT</a></li>
- </ul>
- </li-->
-
Review comment:
So we removed 0.3.0 download link?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine-site] jiwq commented on a change in pull request #16: SUBMARINE-546. Update Submarine Website for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #16:
URL: https://github.com/apache/submarine-site/pull/16#discussion_r445953391
##########
File path: _includes/themes/submarine/_navigation.html
##########
@@ -24,34 +25,27 @@
</ul>
</li>
-
<!-- Download -->
<li><a href="/download.html">Download</a></li>
<!-- Docs -->
- <!--li class="docs">
- <a href="#" data-toggle="dropdown" class="dropdown-toggle">Docs<b class="caret"></b></a>
- <ul class="dropdown-menu">
- <li class="title"><span><b>Release</b><span></li>
- <li><a href="https://hadoop.apache.org/submarine/docs/0.2.0/Index/">0.2.0</a></li>
- <li><a href="http://hadoop.apache.org/submarine/docs/">0.1.0</a></li>
- <li role="separator" class="divider"></li>
- <li class="title"><span><b>Snapshot (development)</b><span></li>
- <li><a href="/docs/0.3.0-SNAPSHOT">0.3.0-SNAPSHOT</a></li>
- </ul>
- </li-->
-
Review comment:
This snippet was commented out and it's not the download link, so we can delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine-site] jiwq commented on pull request #16: SUBMARINE-546. Update Submarine Website for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
jiwq commented on pull request #16:
URL: https://github.com/apache/submarine-site/pull/16#issuecomment-649982731
> I found that website doesn't update after #15 is merged.
Yes, we will publish the site when this PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine-site] jiwq merged pull request #16: SUBMARINE-546. Update Submarine Website for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
jiwq merged pull request #16:
URL: https://github.com/apache/submarine-site/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org