You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/07/20 21:32:24 UTC
[PR] test(pyamber): add unit tests for storage_config [texera]
Ma77Ball opened a new pull request, #6643:
URL: https://github.com/apache/texera/pull/6643
### What changes were proposed in this PR?
- Add unit tests covering StorageConfig.initialize populating every field, setting the initialized flag, coercing commit_batch_size to int, rejecting re-initialization without overwriting existing fields, and the static-class instantiation guard.
### Any related issues, documentation, discussions?
Closes: #6642
### How was this PR tested?
- Run: `cd amber && python -m pytest src/test/python/core/storage/test_storage_config.py`, expect all 6 tests passing
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): add unit tests for storage_config [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6643:
URL: https://github.com/apache/texera/pull/6643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): add unit tests for storage_config [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6643:
URL: https://github.com/apache/texera/pull/6643#issuecomment-5027543651
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6643?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.52%. Comparing base ([`f14cd39`](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1d2a29b`](https://app.codecov.io/gh/apache/texera/commit/1d2a29b6e322a0e5a77d42c431d650f27d57d11e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6643 +/- ##
=========================================
Coverage 74.51% 74.52%
Complexity 3440 3440
=========================================
Files 1157 1157
Lines 45621 45621
Branches 5031 5031
=========================================
+ Hits 33996 33998 +2
+ Misses 9973 9971 -2
Partials 1652 1652
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.82% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `18.00% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.80% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.29% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.88% <ø> (+0.04%)` | :arrow_up: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [f14cd39](https://app.codecov.io/gh/apache/texera/commit/f14cd3975e7446b77241990b7d573d182d61f88f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6643?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): add unit tests for storage_config [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6643:
URL: https://github.com/apache/texera/pull/6643#issuecomment-5027536544
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 3 worse · ⚪ 12 noise (<±5%) · 0 without baseline
> Compared against main `f14cd39` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/29780571218)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 429 | 0.262 | 22,521/31,792/31,792 us | 🔴 +11.3% / 🔴 +103.4% |
| ⚪ | bs=100 sw=10 sl=64 | 910 | 0.555 | 108,855/132,845/132,845 us | ⚪ within ±5% / 🔴 +25.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,094 | 0.668 | 913,490/953,146/953,146 us | ⚪ within ±5% / 🟢 -9.1% |
<details><summary>Baseline details</summary>
Latest main `f14cd39` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 429 tuples/sec | 467 tuples/sec | 767.23 tuples/sec | -8.1% | -44.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.262 MB/s | 0.285 MB/s | 0.468 MB/s | -8.1% | -44.1% |
| bs=10 sw=10 sl=64 | p50 | 22,521 us | 20,241 us | 12,705 us | +11.3% | +77.3% |
| bs=10 sw=10 sl=64 | p95 | 31,792 us | 31,737 us | 15,633 us | +0.2% | +103.4% |
| bs=10 sw=10 sl=64 | p99 | 31,792 us | 31,737 us | 20,214 us | +0.2% | +57.3% |
| bs=100 sw=10 sl=64 | throughput | 910 tuples/sec | 953 tuples/sec | 1,001 tuples/sec | -4.5% | -9.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.555 MB/s | 0.582 MB/s | 0.611 MB/s | -4.6% | -9.2% |
| bs=100 sw=10 sl=64 | p50 | 108,855 us | 103,943 us | 99,949 us | +4.7% | +8.9% |
| bs=100 sw=10 sl=64 | p95 | 132,845 us | 128,082 us | 105,996 us | +3.7% | +25.3% |
| bs=100 sw=10 sl=64 | p99 | 132,845 us | 128,082 us | 117,999 us | +3.7% | +12.6% |
| bs=1000 sw=10 sl=64 | throughput | 1,094 tuples/sec | 1,081 tuples/sec | 1,033 tuples/sec | +1.2% | +5.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.668 MB/s | 0.66 MB/s | 0.631 MB/s | +1.2% | +5.9% |
| bs=1000 sw=10 sl=64 | p50 | 913,490 us | 922,495 us | 974,571 us | -1.0% | -6.3% |
| bs=1000 sw=10 sl=64 | p95 | 953,146 us | 977,040 us | 1,016,467 us | -2.4% | -6.2% |
| bs=1000 sw=10 sl=64 | p99 | 953,146 us | 977,040 us | 1,048,798 us | -2.4% | -9.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,465.77,200,128000,429,0.262,22521.46,31791.81,31791.81
1,100,10,64,20,2198.99,2000,1280000,910,0.555,108855.43,132845.31,132845.31
2,1000,10,64,20,18283.32,20000,12800000,1094,0.668,913490.12,953145.74,953145.74
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(pyamber): add unit tests for storage_config [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6643:
URL: https://github.com/apache/texera/pull/6643#issuecomment-5027494851
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org