You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/04/14 21:27:44 UTC

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24192


Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................

IMPALA-14888: Increase sleep for slow stack test

Increases the sleep duration for the slow stack test to ensure the slow
RPC identification thread has enough time to identify the slow RPC and
log the stack trace. In slow environments like ASAN and UBSAN, the
original duration was insufficient.

Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
---
M tests/observability/test_log_fragments.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/24192/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13323/


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2026 04:40:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22134/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2026 21:50:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1: Verified+1

I agree, failure was in dockerized tests, where test_log_fragments skips all tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2026 17:34:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13323/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2026 00:16:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1: Code-Review+1

The failure is unrelated from the changes and also the build shared in the CDPD jira passed. LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2026 04:57:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2026 16:38:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14888: Increase sleep for slow stack test

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24192 )

Change subject: IMPALA-14888: Increase sleep for slow stack test
......................................................................

IMPALA-14888: Increase sleep for slow stack test

Increases the sleep duration for the slow stack test to ensure the slow
RPC identification thread has enough time to identify the slow RPC and
log the stack trace. In slow environments like ASAN and UBSAN, the
original duration was insufficient.

Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Reviewed-on: http://gerrit.cloudera.org:8080/24192
Reviewed-by: Arnab Karmakar <ar...@gmail.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M tests/observability/test_log_fragments.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Arnab Karmakar: Looks good to me, but someone else must approve
  Jason Fehr: Looks good to me, approved
  Michael Smith: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f367e82500e4907f4284863e9ba2d451698f617
Gerrit-Change-Number: 24192
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>