You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alexander Dejanovski (Jira)" <ji...@apache.org> on 2020/04/01 06:53:00 UTC
[jira] [Commented] (CASSANDRA-15661) Improve logging by using more
appropriate levels
[ https://issues.apache.org/jira/browse/CASSANDRA-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072443#comment-17072443 ]
Alexander Dejanovski commented on CASSANDRA-15661:
--------------------------------------------------
Thanks for adding more info on the native connection limit logging.
I checked the test results and indeed I don't see how changing the logging levels could be responsible for the DTests failure here.
The patch looks good to me now (y)
> Improve logging by using more appropriate levels
> -------------------------------------------------
>
> Key: CASSANDRA-15661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15661
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: Jon Haddad
> Assignee: Jon Haddad
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> There are a number of log statements using logging levels that are a bit too conservative. For example:
> * Flushing memtables is currently at debug. This is a relatively rare event that is important enough to be INFO
> * When compaction finishes we log the progress at debug
> * Different steps in incremental repair are logged as debug, should be INFO
> * when reaching connection limits in ConnectionLimitHandler.java we log at warn rather than error. Since this is a client disconnect it’s more than a warning, we’re taking action and disconnecting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org