You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/04 16:57:55 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar

sijie commented on a change in pull request #3854: [issue #3767] support go function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#discussion_r272274738
 
 

 ##########
 File path: pulsar-function-go/pf/instance.go
 ##########
 @@ -227,6 +231,7 @@ func (gi *GoInstance) processResult(msgInput pulsar.Message, output []byte) {
 					} else if effectivelyOnce {
 						panic("in effectively-once case, this is error.")
 					}
+					log.Fatal(e)
 
 Review comment:
   Doesn’t panic kill the process for EO?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services