[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4614: [relay][test] skip example json runtime test when config is not set

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #4614: [relay][test] skip example json runtime test when config is not set
URL: https://github.com/apache/incubator-tvm/pull/4614#discussion_r362921127
 
 

 ##########
 File path: tests/python/relay/test_external_runtime.py
 ##########
 @@ -492,8 +492,9 @@ def test_engine_extern():
                options=["-O2", "-std=c++11", "-I" + tmp_path.relpath("")])
 
 def test_json_extern():
-    if which("gcc") is None:
-        print("Skip test because gcc is not available.")
+    if not tvm.get_global_func("module.loadfile_examplejson", True):
+        print("Skip because JSON example runtime is not enabled.")
+        return
 
 Review comment:
   Should have a `return` after L447?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services