[jira] [Commented] (LUCENE-3973) Incorporate PMD / FindBugs

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309561#comment-14309561 ] 

Michael McCandless commented on LUCENE-3973:
--------------------------------------------

I think as this stands it's useful and we should commit it and iterate later?

I.e. devs can now run "ant pmd" and see potential issues.

Can I run "ant pmd" inside one module (e.g. lucene/core) and see only the issues for that module?

I think better integration to the build / failing if new warnings show up, etc., can come later?

I use pmd as part of my pre-commit process, but using custom python wrapper; this would already be a step up for me!

> Incorporate PMD / FindBugs
> --------------------------
>
>                 Key: LUCENE-3973
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3973
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Chris Male
>              Labels: newdev
>         Attachments: LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, core.html, solr-core.html
>
>
> This has been touched on a few times over the years.  Having static analysis as part of our build seems like a big win.  For example, we could use PMD to look at {{System.out.println}} statements like discussed in LUCENE-3877 and we could possibly incorporate the nocommit / @author checks as well.
> There are a few things to work out as part of this:
> - Should we use both PMD and FindBugs or just one of them? They look at code from different perspectives (bytecode vs source code) and target different issues.  At the moment I'm in favour of trying both but that might be too heavy handed for our needs.
> - What checks should we use? There's no point having the analysis if it's going to raise too many false-positives or problems we don't deem problematic.  
> - How should the analysis be integrated in our build? Need to work out when the analysis should run, how it should be incorporated in Ant and/or Maven, what impact errors should have.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org