[GitHub] [airflow] ashb commented on a change in pull request #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read time out error

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read time out error
URL: https://github.com/apache/airflow/pull/6643#discussion_r350322075
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -265,12 +265,12 @@ def run(self):
 
     def _run(self, kube_client, resource_version, worker_uuid, kube_config):
         self.log.info(
-            'Event: and now my watch begins starting at resource_version: %s',
-            resource_version
-        )
+            'Event: and now my watch begins starting at resource_version: %s, '
+            'worker_uuid: %s', resource_version, worker_uuid)
         watcher = watch.Watch()
 
-        kwargs = {'label_selector': 'airflow-worker={}'.format(worker_uuid)}
+        kwargs = {'label_selector': 'airflow-worker={}'.format(worker_uuid),
+                  'timeout_seconds': 50}
 
 Review comment:
   Yeah, this should be a config variable at the least.
   
   Also it would be good if https://github.com/apache/airflow/blob/df35957fd4bab86ca6d2c923899569fb23139f56/airflow/config_templates/default_airflow.cfg#L782-L787 applied here (if it doesn't already?) so that this can be set globally for all Kube API calls form airflow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services