You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/26 16:05:21 UTC

[GitHub] [superset] benjreinhart opened a new pull request #14354: chore: add some basic instrumentation to Node WebSocket server

benjreinhart opened a new pull request #14354:
URL: https://github.com/apache/superset/pull/14354


   ### SUMMARY
   This adds some basic instrumentation to the node WebSocket server. For now, adding two counters:
   
   1. Number of connected clients
   2. Number of times the server fails to deliver and event to a client
   
   It'll also collect metrics about the Node process if `collectDefaultMetrics` is `true` in the config file.
   
   ### TEST PLAN
   
   Unit tests, manual
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 commented on pull request #14354: chore: add some basic instrumentation to Node WebSocket server

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #14354:
URL: https://github.com/apache/superset/pull/14354#issuecomment-827140682


   Makes sense. If we want to switch, i think that seems SIP worthy. But would love to learn more about the issues you've been having!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] benjreinhart commented on pull request #14354: chore: add some basic instrumentation to Node WebSocket server

Posted by GitBox <gi...@apache.org>.
benjreinhart commented on pull request #14354:
URL: https://github.com/apache/superset/pull/14354#issuecomment-827010539


   @etr2460 there had been talks on the Preset side around moving to Prometheus given a couple of problems we ran into with statsd. @craig-rueda has more context on those.
   
   I agree that being consistent makes sense, so I think for now we can revert back to statsd.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda merged pull request #14354: chore: add some basic instrumentation to Node WebSocket server

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #14354:
URL: https://github.com/apache/superset/pull/14354


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 commented on pull request #14354: chore: add some basic instrumentation to Node WebSocket server

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #14354:
URL: https://github.com/apache/superset/pull/14354#issuecomment-826974019


   I'm curious, what's the value of Prometheus over statsd here? The main superset app uses statsd for metrics and counters currently, so I wonder if we should use the same protocol for both apps 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org