[jira] [Updated] (BEAM-12116) Consider adding MetricFiltering classes for metrics names with urns and labels.

["Alex Amato (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Amato updated BEAM-12116:
------------------------------
    Status: Open  (was: Triage Needed)

> Consider adding MetricFiltering classes for metrics names with urns and labels. 
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-12116
>                 URL: https://issues.apache.org/jira/browse/BEAM-12116
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-ideas
>            Reporter: Alex Amato
>            Priority: P2
>
> These classes today can only filter metrics with user metric names. Which are defined with a namespace and name string.
> But does not allow filtering metrics defined with a URN + labels.
> I.e. those defined with the MonitoringInfoMetricName class instead of the MetricName class.
> Having this sort of MetricName filtering class would be useful for some SDK/runner use cases such as the metric filtering in MetricContainerImpl.matchMetric.
> We could consider updating the MetricFiltering, MetricNameFilter, MetricFilter, etc. classes with a way to filter metrics defined by URN and laels.
> The problem with doing this though, is that those classes were originally intended to be a public set of methods for querying metrics within your pipeline code. So a better solution would be to have a layer for the public API to do filtering, and an internal layer which can filter based on any MetricName type, including MonitoringInfoMetric name.
> And allow building it based on specific rules, such as hasUrn, hasLabelKey, hasLabelKeyValuePair, etc.)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)