You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/17 16:15:37 UTC
[GitHub] [camel] chandra-h-bitd opened a new pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
chandra-h-bitd opened a new pull request #4244:
URL: https://github.com/apache/camel/pull/4244
…ch as orientation
[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bedlaj commented on pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
bedlaj commented on pull request #4244:
URL: https://github.com/apache/camel/pull/4244#issuecomment-694382860
Thanks. I think this should be mentioned in documentation, so people can actually find that feature. Do you mind mention that in docs? Also small unit test would be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4244:
URL: https://github.com/apache/camel/pull/4244#issuecomment-695204517
You can close this, it has been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chandra-h-bitd commented on pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
chandra-h-bitd commented on pull request #4244:
URL: https://github.com/apache/camel/pull/4244#issuecomment-694763210
@bedlaj , Thanks for your suggestion, I'll update the doc and write a unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chandra-h-bitd commented on pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
chandra-h-bitd commented on pull request #4244:
URL: https://github.com/apache/camel/pull/4244#issuecomment-695203625
Raised new PR with unit test and updated doc --> https://github.com/apache/camel/pull/4253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chandra-h-bitd closed pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
chandra-h-bitd closed pull request #4244:
URL: https://github.com/apache/camel/pull/4244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] chandra-h-bitd commented on pull request #4244: CAMEL-15535 Camel Barcode : Add additional headers to the exchange su…
Posted by GitBox <gi...@apache.org>.
chandra-h-bitd commented on pull request #4244:
URL: https://github.com/apache/camel/pull/4244#issuecomment-695209151
Sure @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org