You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2023/06/27 23:20:37 UTC
[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20129
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895
......................................................................
IMPALA-12248: Add missing configuration properties after RANGER-2895
This patch adds 3 Ranger configuration properties that are required
after RANGER-2895 so that the Ranger HTTP server could be properly
started.
Testing:
- Verified that after this patch Ranger's HTTP server could be started
and that we will be able to update the users, groups, and policies on
the Ranger server with the current scripts in the Impala repository.
Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
---
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/20129/1
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13408/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 23:43:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> (1 comment)
>
> Thank you for working on this, Fang-Yu.
> I just have one request.
Thanks for the review Riza! I have addressed your comments in the previous patch. Let me know if you have any other suggestion.
http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template
File testdata/cluster/ranger/ranger-admin-default-site.xml.template:
http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template@305
PS1, Line 305: ranger.jpa.jdbc.initialpoolsize
> In the JIRA, you mention "In this regard, we could probably add these 3 new
Thanks Riza!
I have revised the commit message in the next patch and also created IMPALA-12250 to keep track of the task of removing the deprecated property.
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 05:52:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 14:55:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895
......................................................................
Patch Set 1:
(1 comment)
Thank you for working on this, Fang-Yu.
I just have one request.
http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template
File testdata/cluster/ranger/ranger-admin-default-site.xml.template:
http://gerrit.cloudera.org:8080/#/c/20129/1/testdata/cluster/ranger/ranger-admin-default-site.xml.template@305
PS1, Line 305: ranger.jpa.jdbc.initialpoolsize
In the JIRA, you mention "In this regard, we could probably add these 3 new properties first and then remove the unnecessary properties once we have bumped up the build number that includes RANGER-2895.".
Can you rephrase that statement into commit message of this patch? Maybe also spell out the config key that is being deprecated.
Are you planning to file a follow up JIRA to remove the deprecated config keys?
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 00:13:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3:
> Patch Set 3: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9464/
This appears to be flakyness in test_cache_invalidate_incomplete_table. I'll try rerun the GVO.
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 23:50:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20129
to look at the new patch set (#2).
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
IMPALA-12248: Add three configuration properties after RANGER-2895
This patch adds 3 Ranger configuration properties that will be required
after we start using a build that includes RANGER-2895 so that Ranger's
HTTP server could be properly started.
On the other hand, recall that a Ranger configuration property was
deprecated in RANGER-2895, i.e.,
ranger.jpa.jdbc.idleconnectiontestperiod. Hence, we should also remove
it when starting using a build that contains RANGER-2895. This task will
be tracked by IMPALA-12250.
Testing:
- Verified that with this patch Ranger's HTTP server could be started
and that we will be able to update the users, groups, and policies on
the Ranger server with the current scripts in the Impala repository
whether or not we are using a build that has RANGER-2895.
Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
---
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/20129/2
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Jun 2023 04:03:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 18:51:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9464/
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 23:04:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9465/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 23:52:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9451/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 23:23:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jun 2023 04:48:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
IMPALA-12248: Add three configuration properties after RANGER-2895
This patch adds 3 Ranger configuration properties that will be required
after we start using a build that includes RANGER-2895 so that Ranger's
HTTP server could be properly started.
On the other hand, recall that a Ranger configuration property was
deprecated in RANGER-2895, i.e.,
ranger.jpa.jdbc.idleconnectiontestperiod. Hence, we should also remove
it when starting using a build that contains RANGER-2895. This task will
be tracked by IMPALA-12250.
Testing:
- Verified that with this patch Ranger's HTTP server could be started
and that we will be able to update the users, groups, and policies on
the Ranger server with the current scripts in the Impala repository
whether or not we are using a build that has RANGER-2895.
Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Reviewed-on: http://gerrit.cloudera.org:8080/20129
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/ranger/ranger-admin-default-site.xml.template
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 )
Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9464/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a27e3fe3ab96a9f60566dc2c87bd72636b91ae
Gerrit-Change-Number: 20129
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jun 2023 18:51:12 +0000
Gerrit-HasComments: No