You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Ruben Q L (Jira)" <ji...@apache.org> on 2020/03/12 13:05:00 UTC

[jira] [Commented] (CALCITE-3853) Minor improvements in SortJoinCopyRule

    [ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057901#comment-17057901 ] 

Ruben Q L commented on CALCITE-3853:
------------------------------------

Fixed via https://github.com/apache/calcite/commit/bc2d7e1ce0ff0a2193df2ce6e59d5501766bbca5

> Minor improvements in SortJoinCopyRule
> --------------------------------------
>
>                 Key: CALCITE-3853
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3853
>             Project: Calcite
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: Ruben Q L
>            Assignee: Ruben Q L
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> A few improvements can be made on SortJoinCopyRule (introduced via CALCITE-2624):
> - The default INSTANCE currently matches LogicalSort + Join, which seems inconsistent, it should match LogicalSort + LogicalJoin
> - The constructor should be public, in order to allow clients to create their own version of the rule



--
This message was sent by Atlassian Jira
(v8.3.4#803005)