You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Matt Smith (JIRA)" <ji...@codehaus.org> on 2005/04/25 09:24:46 UTC
[jira] Created: (MPASPECTJ-19) Add messageHolderClass property
Add messageHolderClass property
-------------------------------
Key: MPASPECTJ-19
URL: http://jira.codehaus.org/browse/MPASPECTJ-19
Project: maven-aspectj-plugin
Type: Improvement
Versions: 3.2
Reporter: Matt Smith
from the iajc ant task documentation:
Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
Adding the ability to use a messageHolderClass requires two changes:
1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
2) add maven.dependency.classpath to the ant task def
Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=comments#action_38108 ]
Vincent Massol commented on MPASPECTJ-19:
-----------------------------------------
Thanks Matt. I'm getting the following which does not sound right (but then I've not read the tests so this may be normal):
C:\dev\maven\maven-1\plugins\trunk\aspectj>maven plugin:test
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.0.2
[warning] couldn't find aspectjrt.jar on classpath, checked: c:\apps\maven-1.0.2\lib\endorsed\xerces-2.4.0.jar;c:\apps\maven-1.0.2
\lib\endorsed\xml-apis-1.0.b2.jar;c:\j2sdk1.4.2_05\jre\lib\rt.jar;c:\j2sdk1.4.2_05\jre\lib\i18n.jar;c:\j2sdk1.4.2_05\jre\lib\sunrs
asign.jar;c:\j2sdk1.4.2_05\jre\lib\jsse.jar;c:\j2sdk1.4.2_05\jre\lib\jce.jar;c:\j2sdk1.4.2_05\jre\lib\charsets.jar;c:\j2sdk1.4.2_0
5\jre\classes;c:\j2sdk1.4.2_05\jre\lib\ext\dnsns.jar;c:\j2sdk1.4.2_05\jre\lib\ext\ldapsec.jar;c:\j2sdk1.4.2_05\jre\lib\ext\localed
ata.jar;c:\j2sdk1.4.2_05\jre\lib\ext\sunjce_provider.jar;C:\Documents and Settings\Vincent Massol\.maven\repository\aspectj\jars\a
spectjrt-1.2.jar;C:\Documents and Settings\Vincent Massol\.maven\repository\aspectj\jars\aspectjrt-1.2.1.jar;C:\dev\maven\maven-1\
plugins\trunk\aspectj\src\plugin-test\target\classes
C:\dev\maven\maven-1\plugins\trunk\aspectj\src\plugin-test\src\aspect\org\apache\maven\aspectj\Sample.aj:25 [warning] no match for
this type name: org.apache.maven.aspectj.AspectTest [Xlint:invalidAbsoluteTypeName]
execution(public * org.apache.maven.aspectj.AspectTest.someMethod());
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[warning] couldn't find aspectjrt.jar on classpath, checked: c:\apps\maven-1.0.2\lib\endorsed\xerces-2.4.0.jar;c:\apps\maven-1.0.2
\lib\endorsed\xml-apis-1.0.b2.jar;c:\j2sdk1.4.2_05\jre\lib\rt.jar;c:\j2sdk1.4.2_05\jre\lib\i18n.jar;c:\j2sdk1.4.2_05\jre\lib\sunrs
asign.jar;c:\j2sdk1.4.2_05\jre\lib\jsse.jar;c:\j2sdk1.4.2_05\jre\lib\jce.jar;c:\j2sdk1.4.2_05\jre\lib\charsets.jar;c:\j2sdk1.4.2_0
5\jre\classes;c:\j2sdk1.4.2_05\jre\lib\ext\dnsns.jar;c:\j2sdk1.4.2_05\jre\lib\ext\ldapsec.jar;c:\j2sdk1.4.2_05\jre\lib\ext\localed
ata.jar;c:\j2sdk1.4.2_05\jre\lib\ext\sunjce_provider.jar;C:\Documents and Settings\Vincent Massol\.maven\repository\aspectj\jars\a
spectjrt-1.2.jar;C:\Documents and Settings\Vincent Massol\.maven\repository\junit\jars\junit-3.8.1.jar;C:\Documents and Settings\V
incent Massol\.maven\repository\aspectj\jars\aspectjrt-1.2.1.jar;C:\dev\maven\maven-1\plugins\trunk\aspectj\src\plugin-test\target
\classes
The 1st and last warnings are ok (they are due to our aspectjrt.jar being named with a version and it seems the "aspectjrt.jar" name is hardcoded in AspectJ's code. Real ugly!). I'm concerned about the warning about "no match for...". Any idea?
Thanks
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Lukas Theussl closed MPASPECTJ-19:
----------------------------------
Resolution: Fixed
Fixed a while ago.
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Fix For: 3.3
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=comments#action_38083 ]
Vincent Massol commented on MPASPECTJ-19:
-----------------------------------------
Thanks. Applied with several modifications:
- it was missing a patch for properties.xml
- it was missing a patch for changes.xml
- the patch was probably invalid when no maven.aspectj.messageHolder property is specified. I hope I've fixed that.
It's also missing a test to prove that it works. Could you please provide one?
Note: I've noticed that the existing plugin test does not seem to fully work so it may need to be fixed too... Thanks! ;-)
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Attachments: MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Lukas Theussl updated MPASPECTJ-19:
-----------------------------------
Fix Version: (was: 3.3)
4.0
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Fix For: 4.0
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Carlos Sanchez updated MPASPECTJ-19:
------------------------------------
Fix Version: 3.3
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Fix For: 3.3
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Matt Smith (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=comments#action_38109 ]
Matt Smith commented on MPASPECTJ-19:
-------------------------------------
Here is what I think is going on. When aspecj:compile goal is executed the AspectTest is not visible. It is only visible when the maven.test.compile.src.set during the aspectj:test-compile. Thus you get the warning. Sample.aj is referencing classes (Dummy and AspectTest) from the sourceDirectory and the test directory. Does that make since or am I off track.
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Matt Smith (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Matt Smith updated MPASPECTJ-19:
--------------------------------
Attachment: MPASPECTJ-19.txt
messageHolderClass diff
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Attachments: MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Lukas Theussl closed MPASPECTJ-19:
----------------------------------
Resolution: Fixed
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Fix For: 4.0
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Matt Smith (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Matt Smith updated MPASPECTJ-19:
--------------------------------
Attachment: MPASPECTJ-19-2.txt
The paths in the argfile.lst needed to be changed from \ to /. The tests run successfully. I will add a test case for the previous patch. Thanks! Matt
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Reopened: (MPASPECTJ-19) Add messageHolderClass property
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPASPECTJ-19?page=all ]
Lukas Theussl reopened MPASPECTJ-19:
------------------------------------
> Add messageHolderClass property
> -------------------------------
>
> Key: MPASPECTJ-19
> URL: http://jira.codehaus.org/browse/MPASPECTJ-19
> Project: maven-aspectj-plugin
> Type: Improvement
> Versions: 3.2
> Reporter: Matt Smith
> Fix For: 4.0
> Attachments: MPASPECTJ-19-2.txt, MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
> 1) add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
> 2) add maven.dependency.classpath to the ant task def
> Please see the attached file
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org