You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-issues@apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2005/08/26 13:10:45 UTC
[jira] Created: (INFRA-531) CVS revisions are getting lost!
CVS revisions are getting lost!
-------------------------------
Key: INFRA-531
URL: http://issues.apache.org/jira/browse/INFRA-531
Project: Infrastructure
Type: Bug
Components: CVS
Reporter: Howard M. Lewis Ship
Priority: Blocker
I thought something odd was going, that I had messed up somehow on my end when this happened a day or two ago.
I then deleted and re-checked out my workspace.
However, this morning I noticed that a file I had changed last night, and checked in, was out of date, as if my change never made it.
I checked my local CVS log (inside Eclipse):
More commits to come...
Checking in framework/src/test/org/apache/tapestry/form/TestForm.java;
/home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v <-- TestForm.java
new revision: 1.2; previous revision: 1.1
But if you view the history of the file:
http://cvs.apache.org/viewcvs.cgi/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java
You'll see that only the 1.1 revision exists
Here's the commit email that CVS sent:
Index: TestForm.java
===================================================================
RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TestForm.java 17 Jun 2005 16:52:19 -0000 1.1
+++ TestForm.java 25 Aug 2005 23:34:19 -0000 1.2
@@ -16,6 +16,8 @@
import org.apache.tapestry.IActionListener;
import org.apache.tapestry.components.BaseComponentTestCase;
+import org.apache.tapestry.valid.IValidationDelegate;
+import org.easymock.MockControl;
/**
* Tests for {@link org.apache.tapestry.form.Form}. Most of the testing is, still alas, done with
@@ -88,19 +90,54 @@
verifyControls();
}
- public void testFindListenerNormal()
+ public void testFindListenerSuccess()
{
IActionListener cancel = newListener();
IActionListener refresh = newListener();
+ IActionListener success = newListener();
IActionListener listener = newListener();
+ IValidationDelegate delegate = newDelegate(false);
+
+ replayControls();
+
+ Form form = (Form) newInstance(Form.class, new Object[]
+ { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
+ "listener", listener });
+
+ assertSame(success, form.findListener(FormConstants.SUBMIT_NORMAL));
+
+ verifyControls();
+ }
+
+ public void testFindListenerValidationErrors()
+ {
+ IActionListener cancel = newListener();
+ IActionListener refresh = newListener();
+ IActionListener success = newListener();
+ IActionListener listener = newListener();
+
+ IValidationDelegate delegate = newDelegate(true);
+
replayControls();
Form form = (Form) newInstance(Form.class, new Object[]
- { "listener", listener, "cancel", cancel, "refresh", refresh });
+ { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
+ "listener", listener });
assertSame(listener, form.findListener(FormConstants.SUBMIT_NORMAL));
verifyControls();
}
+
+ private IValidationDelegate newDelegate(boolean hasErrors)
+ {
+ MockControl control = newControl(IValidationDelegate.class);
+ IValidationDelegate delegate = (IValidationDelegate) control.getMock();
+
+ delegate.getHasErrors();
+ control.setReturnValue(hasErrors);
+
+ return delegate;
+ }
}
So ... what happened to my 1.1 revision?
This is scary! What other code that I've checked in has gotten lost?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (INFRA-531) CVS revisions are getting lost!
Posted by "Jeff Turner (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/INFRA-531?page=all ]
Jeff Turner resolved INFRA-531:
-------------------------------
Resolution: Cannot Reproduce
Let's hope it was a once-off server problem then.. closing the issue.
> CVS revisions are getting lost!
> -------------------------------
>
> Key: INFRA-531
> URL: http://issues.apache.org/jira/browse/INFRA-531
> Project: Infrastructure
> Type: Bug
> Components: CVS
> Reporter: Howard M. Lewis Ship
> Priority: Blocker
>
> I thought something odd was going, that I had messed up somehow on my end when this happened a day or two ago.
> I then deleted and re-checked out my workspace.
> However, this morning I noticed that a file I had changed last night, and checked in, was out of date, as if my change never made it.
> I checked my local CVS log (inside Eclipse):
> More commits to come...
> Checking in framework/src/test/org/apache/tapestry/form/TestForm.java;
> /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v <-- TestForm.java
> new revision: 1.2; previous revision: 1.1
> But if you view the history of the file:
> http://cvs.apache.org/viewcvs.cgi/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java
> You'll see that only the 1.1 revision exists
> Here's the commit email that CVS sent:
> Index: TestForm.java
> ===================================================================
> RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- TestForm.java 17 Jun 2005 16:52:19 -0000 1.1
> +++ TestForm.java 25 Aug 2005 23:34:19 -0000 1.2
> @@ -16,6 +16,8 @@
> import org.apache.tapestry.IActionListener;
> import org.apache.tapestry.components.BaseComponentTestCase;
> +import org.apache.tapestry.valid.IValidationDelegate;
> +import org.easymock.MockControl;
> /**
> * Tests for {@link org.apache.tapestry.form.Form}. Most of the testing is, still alas, done with
> @@ -88,19 +90,54 @@
> verifyControls();
> }
> - public void testFindListenerNormal()
> + public void testFindListenerSuccess()
> {
> IActionListener cancel = newListener();
> IActionListener refresh = newListener();
> + IActionListener success = newListener();
> IActionListener listener = newListener();
> + IValidationDelegate delegate = newDelegate(false);
> +
> + replayControls();
> +
> + Form form = (Form) newInstance(Form.class, new Object[]
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> +
> + assertSame(success, form.findListener(FormConstants.SUBMIT_NORMAL));
> +
> + verifyControls();
> + }
> +
> + public void testFindListenerValidationErrors()
> + {
> + IActionListener cancel = newListener();
> + IActionListener refresh = newListener();
> + IActionListener success = newListener();
> + IActionListener listener = newListener();
> +
> + IValidationDelegate delegate = newDelegate(true);
> +
> replayControls();
> Form form = (Form) newInstance(Form.class, new Object[]
> - { "listener", listener, "cancel", cancel, "refresh", refresh });
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> assertSame(listener, form.findListener(FormConstants.SUBMIT_NORMAL));
> verifyControls();
> }
> +
> + private IValidationDelegate newDelegate(boolean hasErrors)
> + {
> + MockControl control = newControl(IValidationDelegate.class);
> + IValidationDelegate delegate = (IValidationDelegate) control.getMock();
> +
> + delegate.getHasErrors();
> + control.setReturnValue(hasErrors);
> +
> + return delegate;
> + }
> }
> So ... what happened to my 1.1 revision?
> This is scary! What other code that I've checked in has gotten lost?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (INFRA-531) CVS revisions are getting lost!
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/INFRA-531?page=comments#action_12320252 ]
Howard M. Lewis Ship commented on INFRA-531:
--------------------------------------------
I'm afraid the march of progress must go on; I redid the missing work (I hope ... it was several files, not just the one) and checked it in, and tagged thr 4.0-beta-5 release. And we're taking this as a sign to switch over to SVN.
> CVS revisions are getting lost!
> -------------------------------
>
> Key: INFRA-531
> URL: http://issues.apache.org/jira/browse/INFRA-531
> Project: Infrastructure
> Type: Bug
> Components: CVS
> Reporter: Howard M. Lewis Ship
> Priority: Blocker
>
> I thought something odd was going, that I had messed up somehow on my end when this happened a day or two ago.
> I then deleted and re-checked out my workspace.
> However, this morning I noticed that a file I had changed last night, and checked in, was out of date, as if my change never made it.
> I checked my local CVS log (inside Eclipse):
> More commits to come...
> Checking in framework/src/test/org/apache/tapestry/form/TestForm.java;
> /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v <-- TestForm.java
> new revision: 1.2; previous revision: 1.1
> But if you view the history of the file:
> http://cvs.apache.org/viewcvs.cgi/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java
> You'll see that only the 1.1 revision exists
> Here's the commit email that CVS sent:
> Index: TestForm.java
> ===================================================================
> RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- TestForm.java 17 Jun 2005 16:52:19 -0000 1.1
> +++ TestForm.java 25 Aug 2005 23:34:19 -0000 1.2
> @@ -16,6 +16,8 @@
> import org.apache.tapestry.IActionListener;
> import org.apache.tapestry.components.BaseComponentTestCase;
> +import org.apache.tapestry.valid.IValidationDelegate;
> +import org.easymock.MockControl;
> /**
> * Tests for {@link org.apache.tapestry.form.Form}. Most of the testing is, still alas, done with
> @@ -88,19 +90,54 @@
> verifyControls();
> }
> - public void testFindListenerNormal()
> + public void testFindListenerSuccess()
> {
> IActionListener cancel = newListener();
> IActionListener refresh = newListener();
> + IActionListener success = newListener();
> IActionListener listener = newListener();
> + IValidationDelegate delegate = newDelegate(false);
> +
> + replayControls();
> +
> + Form form = (Form) newInstance(Form.class, new Object[]
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> +
> + assertSame(success, form.findListener(FormConstants.SUBMIT_NORMAL));
> +
> + verifyControls();
> + }
> +
> + public void testFindListenerValidationErrors()
> + {
> + IActionListener cancel = newListener();
> + IActionListener refresh = newListener();
> + IActionListener success = newListener();
> + IActionListener listener = newListener();
> +
> + IValidationDelegate delegate = newDelegate(true);
> +
> replayControls();
> Form form = (Form) newInstance(Form.class, new Object[]
> - { "listener", listener, "cancel", cancel, "refresh", refresh });
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> assertSame(listener, form.findListener(FormConstants.SUBMIT_NORMAL));
> verifyControls();
> }
> +
> + private IValidationDelegate newDelegate(boolean hasErrors)
> + {
> + MockControl control = newControl(IValidationDelegate.class);
> + IValidationDelegate delegate = (IValidationDelegate) control.getMock();
> +
> + delegate.getHasErrors();
> + control.setReturnValue(hasErrors);
> +
> + return delegate;
> + }
> }
> So ... what happened to my 1.1 revision?
> This is scary! What other code that I've checked in has gotten lost?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (INFRA-531) CVS revisions are getting lost!
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/INFRA-531?page=comments#action_12320174 ]
Howard M. Lewis Ship commented on INFRA-531:
--------------------------------------------
>From the commit mail message:
From: hlship@apache.org <hl...@apache.org>
Reply-To: Tapestry development <ta...@jakarta.apache.org>
To: jakarta-tapestry-cvs@apache.org
Date: 25 Aug 2005 23:34:19 -0000
Subject: cvs commit: jakarta-tapestry/examples/Workbench/src/java/org/apache/tapestry/workbench/chart ChartPage.java
To establish the time of the event. Henri thinks the server may have been misbehaving at that time. Gives me the willies to think of my source code "at risk".
> CVS revisions are getting lost!
> -------------------------------
>
> Key: INFRA-531
> URL: http://issues.apache.org/jira/browse/INFRA-531
> Project: Infrastructure
> Type: Bug
> Components: CVS
> Reporter: Howard M. Lewis Ship
> Priority: Blocker
>
> I thought something odd was going, that I had messed up somehow on my end when this happened a day or two ago.
> I then deleted and re-checked out my workspace.
> However, this morning I noticed that a file I had changed last night, and checked in, was out of date, as if my change never made it.
> I checked my local CVS log (inside Eclipse):
> More commits to come...
> Checking in framework/src/test/org/apache/tapestry/form/TestForm.java;
> /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v <-- TestForm.java
> new revision: 1.2; previous revision: 1.1
> But if you view the history of the file:
> http://cvs.apache.org/viewcvs.cgi/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java
> You'll see that only the 1.1 revision exists
> Here's the commit email that CVS sent:
> Index: TestForm.java
> ===================================================================
> RCS file: /home/cvs/jakarta-tapestry/framework/src/test/org/apache/tapestry/form/TestForm.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- TestForm.java 17 Jun 2005 16:52:19 -0000 1.1
> +++ TestForm.java 25 Aug 2005 23:34:19 -0000 1.2
> @@ -16,6 +16,8 @@
> import org.apache.tapestry.IActionListener;
> import org.apache.tapestry.components.BaseComponentTestCase;
> +import org.apache.tapestry.valid.IValidationDelegate;
> +import org.easymock.MockControl;
> /**
> * Tests for {@link org.apache.tapestry.form.Form}. Most of the testing is, still alas, done with
> @@ -88,19 +90,54 @@
> verifyControls();
> }
> - public void testFindListenerNormal()
> + public void testFindListenerSuccess()
> {
> IActionListener cancel = newListener();
> IActionListener refresh = newListener();
> + IActionListener success = newListener();
> IActionListener listener = newListener();
> + IValidationDelegate delegate = newDelegate(false);
> +
> + replayControls();
> +
> + Form form = (Form) newInstance(Form.class, new Object[]
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> +
> + assertSame(success, form.findListener(FormConstants.SUBMIT_NORMAL));
> +
> + verifyControls();
> + }
> +
> + public void testFindListenerValidationErrors()
> + {
> + IActionListener cancel = newListener();
> + IActionListener refresh = newListener();
> + IActionListener success = newListener();
> + IActionListener listener = newListener();
> +
> + IValidationDelegate delegate = newDelegate(true);
> +
> replayControls();
> Form form = (Form) newInstance(Form.class, new Object[]
> - { "listener", listener, "cancel", cancel, "refresh", refresh });
> + { "delegate", delegate, "success", success, "cancel", cancel, "refresh", refresh,
> + "listener", listener });
> assertSame(listener, form.findListener(FormConstants.SUBMIT_NORMAL));
> verifyControls();
> }
> +
> + private IValidationDelegate newDelegate(boolean hasErrors)
> + {
> + MockControl control = newControl(IValidationDelegate.class);
> + IValidationDelegate delegate = (IValidationDelegate) control.getMock();
> +
> + delegate.getHasErrors();
> + control.setReturnValue(hasErrors);
> +
> + return delegate;
> + }
> }
> So ... what happened to my 1.1 revision?
> This is scary! What other code that I've checked in has gotten lost?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira