You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "leixm (via GitHub)" <gi...@apache.org> on 2023/03/30 11:33:17 UTC
[GitHub] [incubator-uniffle] leixm commented on a diff in pull request #775: [#757] feat(server): separate flush thread pools for different storage types
leixm commented on code in PR #775:
URL: https://github.com/apache/incubator-uniffle/pull/775#discussion_r1153124111
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -82,11 +82,17 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(60 * 1000L)
.withDescription("rss heartbeat interval ms");
- public static final ConfigOption<Integer> SERVER_FLUSH_THREAD_POOL_SIZE = ConfigOptions
- .key("rss.server.flush.threadPool.size")
+ public static final ConfigOption<Integer> SERVER_FLUSH_LOCALFILE_THREAD_POOL_SIZE = ConfigOptions
+ .key("rss.server.flush.local-file.threadPool.size")
.intType()
.defaultValue(10)
- .withDescription("thread pool for flush data to file");
+ .withDescription("thread pool for flush data to local file");
+
+ public static final ConfigOption<Integer> SERVER_FLUSH_HDFS_THREAD_POOL_SIZE = ConfigOptions
+ .key("rss.server.flush.hdfs.threadPool.size")
+ .intType()
+ .defaultValue(10)
+ .withDescription("thread pool for flush data to hdfs");
public static final ConfigOption<Integer> SERVER_FLUSH_THREAD_POOL_QUEUE_SIZE = ConfigOptions
Review Comment:
This is useful to flush the waiting queue of the thread pool.
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -82,11 +82,17 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(60 * 1000L)
.withDescription("rss heartbeat interval ms");
- public static final ConfigOption<Integer> SERVER_FLUSH_THREAD_POOL_SIZE = ConfigOptions
- .key("rss.server.flush.threadPool.size")
+ public static final ConfigOption<Integer> SERVER_FLUSH_LOCALFILE_THREAD_POOL_SIZE = ConfigOptions
+ .key("rss.server.flush.local-file.threadPool.size")
Review Comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org