[GitHub] [spark] amaliujia commented on pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on PR #41836:
URL: https://github.com/apache/spark/pull/41836#issuecomment-1619491849

   Per my understanding, this PR creates a new interface for DataType parsing and also extract the parsing code. I guess the ultimate goal is we only move Datatype parsing (so not entire SQL grammar) to sql/api.
   
   The idea LGTM. This is the best we can achieve for the parser relocation. 
   
   For the detailed interfaces, I am ok with the splitting so also LGTM. However I may not be the best person to comment the current way of constructing the new interface in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org