You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/22 12:08:20 UTC
[GitHub] [activemq-artemis] ehsavoie opened a new pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
ehsavoie opened a new pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768
… private constructor.
* Removing the 'private' constructor
* Removing the use of a static getInstance
Issue: https://issues.apache.org/jira/browse/ARTEMIS-3494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] ehsavoie commented on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925056278
I was recreating an ActiveMQConnectionFactory from a 'previous' one but when setting the ProtocolManagerFactory it fails because the code underlying is using an empty constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925052446
@ehsavoie, can you clarify why this change is necessary/beneficial?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] ehsavoie edited a comment on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
ehsavoie edited a comment on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925056278
@jbertram I was recreating an ActiveMQConnectionFactory from a 'previous' one but when setting the ProtocolManagerFactory it fails because the code underlying is using an empty constructor
@see https://github.com/apache/activemq-artemis/blob/main/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java#L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925958580
Seems unusual to explicitly render the static method unused in the Artemis codebase and then not modify it in some way (e.g deprecation, or removal). As is anyone could just choose to remove it as 'unused', though it sounds like you may have existing code that was relying on it. Its also now unused and untested for anyone else still relying on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] ehsavoie edited a comment on pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
ehsavoie edited a comment on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925056278
I was recreating an ActiveMQConnectionFactory from a 'previous' one but when setting the ProtocolManagerFactory it fails because the code underlying is using an empty constructor
@see https://github.com/apache/activemq-artemis/blob/main/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java#L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev merged pull request #3768: [ARTEMIS-3494]: ActiveMQClientProtocolManagerFactory shouldn't have a…
Posted by GitBox <gi...@apache.org>.
brusdev merged pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org