You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/21 08:53:07 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request, #2831: [Binary-Package]Add script to automatically download plugins
CalvinKirs opened a new pull request, #2831:
URL: https://github.com/apache/incubator-seatunnel/pull/2831
Binary package releases no longer package connector plugins. The declaration -Prelease needs to be displayed, otherwise it is still included.
Provides a script to automatically download plugins (we use maven-wrapper)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] dijiekstra merged pull request #2831: [Binary-Package]Add script to automatically download plugins
Posted by GitBox <gi...@apache.org>.
dijiekstra merged PR #2831:
URL: https://github.com/apache/incubator-seatunnel/pull/2831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2831: [Binary-Package]Add script to automatically download plugins
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2831:
URL: https://github.com/apache/incubator-seatunnel/pull/2831#discussion_r976379426
##########
config/plugin.properties:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+# This mapping is used to resolve the Jar package name without version (or call artifactId)
+#
+# corresponding to the module in the user Config, helping SeaTunnel to load the correct Jar package.
+# Don't modify the delimiter " -- ", just select the plugin you need
+--flink-sql-connectors--
Review Comment:
hi, thanks for your review, this is our custom format, maybe it would be better not to add a suffix, I modified it, you can take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] dijiekstra commented on pull request #2831: [Binary-Package]Add script to automatically download plugins
Posted by GitBox <gi...@apache.org>.
dijiekstra commented on PR #2831:
URL: https://github.com/apache/incubator-seatunnel/pull/2831#issuecomment-1254473254
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a diff in pull request #2831: [Binary-Package]Add script to automatically download plugins
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #2831:
URL: https://github.com/apache/incubator-seatunnel/pull/2831#discussion_r976363110
##########
config/plugin.properties:
##########
@@ -0,0 +1,92 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+# This mapping is used to resolve the Jar package name without version (or call artifactId)
+#
+# corresponding to the module in the user Config, helping SeaTunnel to load the correct Jar package.
+# Don't modify the delimiter " -- ", just select the plugin you need
+--flink-sql-connectors--
Review Comment:
This file is not `.properties` format but use a `.properties` file extension, this is not a good ideal it can confuse users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org