You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sanpwc (via GitHub)" <gi...@apache.org> on 2024/10/22 08:34:23 UTC
[PR] IGNITE-23503 Add maxObservableSafeTime awaiting logic on SafeTimeReorderException [ignite-3]
sanpwc opened a new pull request, #4612:
URL: https://github.com/apache/ignite-3/pull/4612
https://issues.apache.org/jira/browse/IGNITE-23503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23503 Add maxObservableSafeTime awaiting logic on SafeTimeReorderException [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #4612:
URL: https://github.com/apache/ignite-3/pull/4612#discussion_r1812324626
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2662,20 +2662,32 @@ private <T> void applyCmdWithRetryOnSafeTimeReorderException(Command cmd, Comple
new ReplicationMaxRetriesExceededException(replicationGroupId, MAX_RETIES_ON_SAFE_TIME_REORDERING));
}
+ int attemptsCounter0 = attemptsCounter;
Review Comment:
Because of "Variable used in lambda expression should be final or effectively final"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23503 Add maxObservableSafeTime awaiting logic on SafeTimeReorderException [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #4612:
URL: https://github.com/apache/ignite-3/pull/4612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23503 Add maxObservableSafeTime awaiting logic on SafeTimeReorderException [ignite-3]
Posted by "denis-chudov (via GitHub)" <gi...@apache.org>.
denis-chudov commented on code in PR #4612:
URL: https://github.com/apache/ignite-3/pull/4612#discussion_r1812298367
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2662,20 +2662,32 @@ private <T> void applyCmdWithRetryOnSafeTimeReorderException(Command cmd, Comple
new ReplicationMaxRetriesExceededException(replicationGroupId, MAX_RETIES_ON_SAFE_TIME_REORDERING));
Review Comment:
```suggestion
new ReplicationMaxRetriesExceededException(replicationGroupId, MAX_RETRIES_ON_SAFE_TIME_REORDERING));
```
##########
modules/core/src/main/java/org/apache/ignite/internal/lang/SafeTimeReorderException.java:
##########
@@ -23,13 +23,26 @@
* This exception is used to indicate a detection of a safe time reordering.
*/
public class SafeTimeReorderException extends IgniteInternalException {
+ /** maxObservableSafeTime at the moment of violation. */
+ private final long maxObservableSafeTimeViolatedValue;
/**
* The constructor.
+ *
+ * @param maxObservableSafeTimeViolatedValue maxObservableSafeTime at the moment of violation
*/
- public SafeTimeReorderException() {
+ public SafeTimeReorderException(long maxObservableSafeTimeViolatedValue) {
super(REPLICATION_SAFE_TIME_REORDERING_ERR, "Replication safe time reordering detected.");
+ this.maxObservableSafeTimeViolatedValue = maxObservableSafeTimeViolatedValue;
}
+ /**
+ * maxObservableSafeTime at the moment of violation.
Review Comment:
```suggestion
* {@code maxObservableSafeTime} at the moment of violation.
```
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2662,20 +2662,32 @@ private <T> void applyCmdWithRetryOnSafeTimeReorderException(Command cmd, Comple
new ReplicationMaxRetriesExceededException(replicationGroupId, MAX_RETIES_ON_SAFE_TIME_REORDERING));
}
+ int attemptsCounter0 = attemptsCounter;
Review Comment:
why not move it to whenComplete block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org