You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Deepak Jaiswal <dj...@hortonworks.com> on 2018/08/01 00:24:00 UTC

Re: Review Request 68124: HIVE-20252


> On July 31, 2018, 11:38 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
> > Line 914 (original), 917 (patched)
> > <https://reviews.apache.org/r/68124/diff/2/?file=2065678#file2065678line983>
> >
> >     Can be collapsed into single line in if condition.

I have been asked to not do that in other reviews before so I kept it that way. Lets keep it this way.


- Deepak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68124/#review206707
-----------------------------------------------------------


On July 31, 2018, 11:07 p.m., Deepak Jaiswal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68124/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 11:07 p.m.)
> 
> 
> Review request for hive, Jesús Camacho Rodríguez and Jason Dere.
> 
> 
> Bugs: HIVE-20252
>     https://issues.apache.org/jira/browse/HIVE-20252
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See Jira.
> 
> removeSemiJoinCyclesDueToMapsideJoins is deprecated, although it has changes. I will eventually remove it and can be ignored.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 538aa5e924 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java c3eb886fd2 
> 
> 
> Diff: https://reviews.apache.org/r/68124/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>