[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #675: Fix various errors found by long running delta-streamer tests

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #675: Fix various errors found by long running delta-streamer tests
URL: https://github.com/apache/incubator-hudi/pull/675#discussion_r283445975
 
 

 ##########
 File path: hoodie-utilities/src/main/java/com/uber/hoodie/utilities/deltastreamer/HoodieDeltaStreamer.java
 ##########
 @@ -276,24 +276,42 @@ public void sync() throws Exception {
       throw new HoodieDeltaStreamerException("Unknown operation :" + cfg.operation);
     }
 
-    // Simply commit for now. TODO(vc): Support better error handlers later on
-    HashMap<String, String> checkpointCommitMetadata = new HashMap<>();
-    checkpointCommitMetadata.put(CHECKPOINT_KEY, checkpointStr);
-
-    boolean success = client.commit(commitTime, writeStatusRDD,
-        Optional.of(checkpointCommitMetadata));
-    if (success) {
-      log.info("Commit " + commitTime + " successful!");
-      // TODO(vc): Kick off hive sync from here.
+    long totalErrorRecords = writeStatusRDD.mapToDouble(ws -> ws.getTotalErrorRecords()).sum().longValue();
 
 Review comment:
   @vinothchandar : DataSource handles error records correctly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services