You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "ShivanshhhG (via GitHub)" <gi...@apache.org> on 2026/10/19 04:35:35 UTC

[PR] [GH-3472] Fix NAD27 ST_Transform and correct grid file documentation [sedona]

ShivanshhhG opened a new pull request, #3479:
URL: https://github.com/apache/sedona/pull/3479

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #3472
   
   ## What changes were proposed in this PR?
   
   This PR resolves #3472 where transformations involving NAD27 coordinate reference systems return `POINT (NaN NaN)`:
   1. **Bump `proj4sedona` to 0.1.7**: In `proj4sedona` 0.1.6, NAD27 resolved to optional grid files (`@conus,@alaska,@ntv2_0.gsb,@ntv1_can.dat`) and routed every transform through WGS84, returning NaN when no grid was loaded. `proj4sedona` 0.1.7 skips datum shifts when no grid is loaded instead of failing.
   2. **Correct Grid File Documentation**: In `docs/api/sql/CRS-Transformation.md` and `docs/api/sql/CRS-Transformation.zh.md`, clarified that CDN auto-fetch by bare filename is disabled in Sedona, so grids must be specified as local file paths or full HTTPS URLs (e.g. `https://cdn.proj.org/...`), with `@` marking the grid as optional.
   3. **Tests**: Added test cases in `CRSTransformProj4Test.scala` verifying that transforms involving NAD27 EPSG codes (such as `EPSG:32041` -> `EPSG:4267`, and `EPSG:4267` -> `EPSG:4326`) return finite coordinates without returning NaN.
   
   ## How was this patch tested?
   
   - Added unit test in `CRSTransformProj4Test.scala`: `"should transform NAD27 coordinate systems without returning NaN (GH-3472)"`.
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-3472] Fix NAD27 ST_Transform and correct grid file documentation [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu closed pull request #3479: [GH-3472] Fix NAD27 ST_Transform and correct grid file documentation
URL: https://github.com/apache/sedona/pull/3479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-3472] Fix NAD27 ST_Transform and correct grid file documentation [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #3479:
URL: https://github.com/apache/sedona/pull/3479#issuecomment-6280803420

   Thanks. I already have a pr to fix this https://github.com/apache/sedona/pull/3473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org