You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2017/01/31 17:54:49 UTC
[GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
GitHub user zellerh opened a pull request:
https://github.com/apache/incubator-trafodion/pull/940
[TRAFODION-2457] Re-enable compGeneral/TEST042 and try to stabilize
Implemented suggestions made by Suresh and Selva. Suresh found out
that the test gives different results when authorization is
initialized, and that caused problems because it is usually
initialized on developer workstations but not on Jenkins.
Suresh and Selva suggested to suppress the key length, since that can
vary with different CQD settings like SCHEMA.
Added the queries to the log and expected files to see whether that
will make failure diagnosis easier. The queries get filtered out, so
should not cause test failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/incubator-trafodion bug/cses_jan-17
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/940.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #940
----
commit 715d8b05e14b825be4da83ec7d329b2d07cd7ece
Author: Hans Zeller <hz...@apache.org>
Date: 2017-01-31T17:33:00Z
[TRAFODION-2457] Re-enable compGeneral/TEST042 and try to stabilize
Implemented suggestions made by Suresh and Selva. Suresh found out
that the test gives different results when authorization is
initialized, and that caused problems because it is usually
initialized on developer workstations but not on Jenkins.
Suresh and Selva suggested to suppress the key length, since that can
vary with different CQD settings like SCHEMA.
Added the queries to the log and expected files to see whether that
will make failure diagnosis easier. The queries get filtered out, so
should not cause test failures.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/940#discussion_r98781522
--- Diff: core/sql/regress/compGeneral/TEST042 ---
@@ -229,6 +229,10 @@ values (600,52,43,4.12345678,6.0932);
--
insert into p9tab (c5) values (0E0);
+-- caching behavior changes with or without authorization initialized,
+-- make sure authorization is initialized when we run this test
+initialize authorization;
--- End diff --
So, do we get an error if authorization is already initialized? Is the error filtered out of the diffs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/940#discussion_r98784962
--- Diff: core/sql/regress/compGeneral/TEST042 ---
@@ -229,6 +229,10 @@ values (600,52,43,4.12345678,6.0932);
--
insert into p9tab (c5) values (0E0);
+-- caching behavior changes with or without authorization initialized,
+-- make sure authorization is initialized when we run this test
+initialize authorization;
--- End diff --
No error is generated if authorization is already initialized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/940#discussion_r98790584
--- Diff: core/sql/regress/compGeneral/TEST042 ---
@@ -229,6 +229,10 @@ values (600,52,43,4.12345678,6.0932);
--
insert into p9tab (c5) values (0E0);
+-- caching behavior changes with or without authorization initialized,
+-- make sure authorization is initialized when we run this test
+initialize authorization;
--- End diff --
Thanks. From what I saw in my tests, initialize authorization does not return an error, but it may print out some diagnostics when it actually creates or upgrades some tables. That's ok, because this command is not being logged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---