[GitHub] [helix] junkaixue commented on a change in pull request #1913: Implement RestSnapShot and substitute the kv maps in HelixDataAccessorWrapper to a RestSnapShot object

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1913:
URL: https://github.com/apache/helix/pull/1913#discussion_r760508732



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java
##########
@@ -91,6 +93,35 @@ public HelixDataAccessorWrapper(ZKHelixDataAccessor dataAccessor,
     super(dataAccessor);
     _restClient = customRestClient;
     _namespace = namespace;
+    _restSnapShot = new RestSnapshotWrapper(_clusterName);
+  }
+
+  static class RestSnapshotWrapper extends RestSnapShot {

Review comment:
       Why we need this wrapper extend it? If we would like to make this RestSnapShot interface. We can have an impl for it. But if we already have a generic kv snapshot. We dont need to extend the class, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org