You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by kk...@apache.org on 2020/04/30 05:56:00 UTC
[kafka] branch 2.5 updated: MINOR: Fix unused arguments used in
formatted string and log messages (#8036)
This is an automated email from the ASF dual-hosted git repository.
kkarantasis pushed a commit to branch 2.5
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.5 by this push:
new f47e039 MINOR: Fix unused arguments used in formatted string and log messages (#8036)
f47e039 is described below
commit f47e039bd9f8951afae79695a8631f8f528b2f15
Author: Chia-Ping Tsai <ch...@gmail.com>
AuthorDate: Thu Apr 30 13:37:05 2020 +0800
MINOR: Fix unused arguments used in formatted string and log messages (#8036)
Reviewers: Ron Dagostino <rd...@confluent.io>, Ismael Juma <is...@juma.me.uk>, Konstantine Karantasis <ko...@confluent.io>
---
.../main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java | 2 +-
.../src/main/java/org/apache/kafka/connect/runtime/Worker.java | 2 +-
.../src/main/java/org/apache/kafka/connect/util/TopicAdmin.java | 6 +++---
.../main/java/org/apache/kafka/message/MessageDataGenerator.java | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java b/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
index f16a71e..587faec 100644
--- a/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
+++ b/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
@@ -2849,7 +2849,7 @@ public class KafkaAdminClient extends AdminClient {
context.future().complete(consumerGroupDescription);
} else {
context.future().completeExceptionally(new IllegalArgumentException(
- String.format("GroupId {} is not a consumer group ({}).",
+ String.format("GroupId %s is not a consumer group (%s).",
context.groupId(), protocolType)));
}
}
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
index 39390f2..cb9aa75 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
@@ -537,7 +537,7 @@ public class Worker {
valueConverter, headerConverter, transformationChain, consumer, loader, time,
retryWithToleranceOperator, herder.statusBackingStore());
} else {
- log.error("Tasks must be a subclass of either SourceTask or SinkTask", task);
+ log.error("Tasks must be a subclass of either SourceTask or SinkTask and current is {}", task);
throw new ConnectException("Tasks must be a subclass of either SourceTask or SinkTask");
}
}
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java b/connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java
index 1fa04de..e644e80 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java
@@ -236,19 +236,19 @@ public class TopicAdmin implements AutoCloseable {
continue;
}
if (cause instanceof UnsupportedVersionException) {
- log.debug("Unable to create topic(s) '{}' since the brokers at {} do not support the CreateTopics API.",
+ log.debug("Unable to create topic(s) '{}' since the brokers at {} do not support the CreateTopics API." +
" Falling back to assume topic(s) exist or will be auto-created by the broker.",
topicNameList, bootstrapServers);
return Collections.emptySet();
}
if (cause instanceof ClusterAuthorizationException) {
- log.debug("Not authorized to create topic(s) '{}'." +
+ log.debug("Not authorized to create topic(s) '{}' upon the brokers {}." +
" Falling back to assume topic(s) exist or will be auto-created by the broker.",
topicNameList, bootstrapServers);
return Collections.emptySet();
}
if (cause instanceof TopicAuthorizationException) {
- log.debug("Not authorized to create topic(s) '{}'." +
+ log.debug("Not authorized to create topic(s) '{}' upon the brokers {}." +
" Falling back to assume topic(s) exist or will be auto-created by the broker.",
topicNameList, bootstrapServers);
return Collections.emptySet();
diff --git a/generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java b/generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
index e1bd59a..e4afb00 100644
--- a/generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
+++ b/generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
@@ -1108,7 +1108,7 @@ public final class MessageDataGenerator {
lengthExpression = "_stringBytes.length";
} else if (type.isBytes()) {
if (zeroCopy) {
- lengthExpression = String.format("%s.remaining()", name, name);
+ lengthExpression = String.format("%s.remaining()", name);
} else {
lengthExpression = String.format("%s.length", name);
}