You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:43:59 UTC
[GitHub] [solr] cpoerschke opened a new pull request #45: SOLR-15281: Add optional SOLR_GC_LOGS_DIR and SOLR_GC_LOG_FILE options for bin/solr
cpoerschke opened a new pull request #45:
URL: https://github.com/apache/solr/pull/45
* `bin/solr` changes - ready for review
* `bin/solr.cmd` changes - to do (help needed)
https://issues.apache.org/jira/browse/SOLR-15281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #45: SOLR-15281: Add optional SOLR_GC_LOGS_DIR and SOLR_GC_LOG_FILE options for bin/solr
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #45:
URL: https://github.com/apache/solr/pull/45#discussion_r600436323
##########
File path: solr/bin/solr
##########
@@ -2004,7 +2012,7 @@ if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
Review comment:
Oops, yes i meant to edit the `archive_gc_logs` instead of the `archive_console_logs` line, good catch!
##########
File path: solr/bin/solr
##########
@@ -2004,7 +2012,7 @@ if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
Review comment:
```suggestion
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_GC_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
```
##########
File path: solr/bin/solr
##########
@@ -2004,7 +2012,7 @@ if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
- #run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -archive_console_logs || echo "Failed archiving old console logs"
+ #run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_GC_LOGS_DIR" $q -archive_console_logs || echo "Failed archiving old console logs"
Review comment:
```suggestion
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -archive_console_logs || echo "Failed archiving old console logs"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #45: SOLR-15281: Add optional SOLR_GC_LOGS_DIR and SOLR_GC_LOG_FILE options for bin/solr
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #45:
URL: https://github.com/apache/solr/pull/45#discussion_r600405604
##########
File path: solr/bin/solr
##########
@@ -2004,7 +2012,7 @@ if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
Review comment:
Did you intend to edit the line above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #45: SOLR-15281: Add optional SOLR_GC_LOGS_DIR and SOLR_GC_LOG_FILE options for bin/solr
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #45:
URL: https://github.com/apache/solr/pull/45#discussion_r600439605
##########
File path: solr/bin/solr
##########
@@ -2003,7 +2011,7 @@ fi
if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
- #run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
+ #run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_GC_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
Review comment:
```suggestion
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_GC_LOGS_DIR" $q -archive_gc_logs $q || echo "Failed archiving old GC logs"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #45: SOLR-15281: Add optional SOLR_GC_LOGS_DIR and SOLR_GC_LOG_FILE options for bin/solr
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #45:
URL: https://github.com/apache/solr/pull/45#discussion_r600438731
##########
File path: solr/bin/solr
##########
@@ -2004,7 +2012,7 @@ if [ "${SOLR_LOG_PRESTART_ROTATION:=false}" == "true" ]; then
# Enable any of these if you require old remove/archive behavior
#run_tool utils -s "$DEFAULT_SERVER_DIR" -l "$SOLR_LOGS_DIR" $q -remove_old_solr_logs 7 || echo "Failed removing old solr logs"
Review comment:
Nit-pick, the `||` used to be aligned above eachother :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org