You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by vanzin <gi...@git.apache.org> on 2019/01/02 19:54:02 UTC

[GitHub] incubator-livy pull request #131: [LIVY-538] Add integration tests for thrif...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/131#discussion_r244836308
  
    --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftServer.scala ---
    @@ -138,6 +139,16 @@ class LivyThriftServer(
         session.owner == user || accessManager.checkModifyPermissions(user)
       }
     
    +  def getJdbcUrl: String = {
    +    val additionalUrlParams = if (thriftCLIService.isInstanceOf[ThriftHttpCLIService]) {
    --- End diff --
    
    Can't you control the bind host via `THRIFT_BIND_HOST`?
    
    It just seems like a lot of code for very little gain.


---