You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/01/22 06:50:08 UTC
[GitHub] incubator-guacamole-manual pull request #25: GUACAMOLE-99: Document new GUAC...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/25
GUACAMOLE-99: Document new GUACD_HOSTNAME and GUACD_PORT variables.
This change required reorganizing/rewriting much of the Docker chapter. Things were previously described rather monolithically:
* MySQL + guacd Docker link
* PostgreSQL + guacd Docker link
* LDAP + guacd Docker link
This is convenient in the sense that it provides a set of discrete sections with steps that can be followed more-or-less robotically, but it also duplicates configuration details common to each.
Because [GUACAMOLE-99](https://issues.apache.org/jira/browse/GUACAMOLE-99) adds support for using `GUACD_HOSTNAME` and `GUACD_PORT` instead of a Docker link, I was faced with the nauseating prospect of doubling what was already duplicated. I don't like doing work that is O(2^n), and chose to restructure things instead:
* guacd (link or environment variables)
* MySQL
* PostgreSQL
* LDAP
Hopefully this will also make things more maintainable going forward.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-manual document-guacd-vars
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 1b583381191f00827a704ebe4e2117359b8f33c9
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-22T03:00:18Z
GUACAMOLE-99: Document new GUACD_HOSTNAME and GUACD_PORT variables. Restructure as necessary.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #25: GUACAMOLE-99: Document new GUAC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---