You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/09/01 16:06:15 UTC
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7934
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
gradle: convert gradle-wrapper.properties into a real generated file
Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.
I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.
Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.
Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Reviewed-on: http://gerrit.cloudera.org:8080/7927
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit cc0b19e912de7126a25695466215803c3efbaa4c)
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/7934/1
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
gradle: convert gradle-wrapper.properties into a real generated file
Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.
I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.
Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.
Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Reviewed-on: http://gerrit.cloudera.org:8080/7927
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit cc0b19e912de7126a25695466215803c3efbaa4c)
Reviewed-on: http://gerrit.cloudera.org:8080/7934
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has restored this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) gradle: convert gradle-wrapper.properties into a real generated file
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins