You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2019/09/11 22:02:15 UTC

svn commit: r1866810 - in /poi: site/src/documentation/content/xdocs/changes.xml trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java

Author: kiwiwings
Date: Wed Sep 11 22:02:14 2019
New Revision: 1866810

URL: http://svn.apache.org/viewvc?rev=1866810&view=rev
Log:
#63541 - NullPointerException from XSLFSimpleShape.getAnchor for empty xfrm tags

Modified:
    poi/site/src/documentation/content/xdocs/changes.xml
    poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java

Modified: poi/site/src/documentation/content/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/poi/site/src/documentation/content/xdocs/changes.xml?rev=1866810&r1=1866809&r2=1866810&view=diff
==============================================================================
--- poi/site/src/documentation/content/xdocs/changes.xml (original)
+++ poi/site/src/documentation/content/xdocs/changes.xml Wed Sep 11 22:02:14 2019
@@ -91,6 +91,7 @@
         <summary-item>Improved chart support: more types and some API changes around angles and width units</summary-item>
       </summary>
       <actions>
+        <action dev="PD" type="fix" fixes-bug="63541" context="XSLF">NullPointerException from XSLFSimpleShape.getAnchor for empty xfrm tags</action>
         <action dev="PD" type="add" fixes-bug="63745" context="POI_Overall">Add traversing and debugging interface</action>
         <action dev="PD" type="fix" fixes-bug="57423,62711" context="XSSF">Fix regression when XSSFRow.shiftRows() is used</action>
         <action dev="PD" type="fix" fixes-bug="63580" context="SL_Common HSLF XSLF">Fix texture paint handling</action>

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java?rev=1866810&r1=1866809&r2=1866810&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSimpleShape.java Wed Sep 11 22:02:14 2019
@@ -151,7 +151,7 @@ public abstract class XSLFSimpleShape ex
     public Rectangle2D getAnchor() {
 
         CTTransform2D xfrm = getXfrm(false);
-        if (xfrm == null) {
+        if (xfrm == null || !xfrm.isSetOff()) {
             return null;
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org