[GitHub] [cassandra] Maxwell-Guo commented on a diff in pull request #2399: CASSANDRA-17818-4.0 or more: Fix error message handling when trying to use CLUSTERING ORDER with non-clustering column

["Maxwell-Guo (via GitHub)" <gi...@apache.org>]

Maxwell-Guo commented on code in PR #2399:
URL: https://github.com/apache/cassandra/pull/2399#discussion_r1223734467


##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java:
##########
@@ -218,6 +218,13 @@ public TableMetadata.Builder builder(Types types)
         if (clusteringOrder.size() > clusteringColumns.size())
             throw ire("Only clustering columns can be defined in CLUSTERING ORDER directive");
 
+        for (ColumnIdentifier orederId: clusteringOrder.keySet())
+        {
+            if (!clusteringColumns.contains(orederId)){

Review Comment:
   I think we should move line 223's '{' to a new line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org