You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/03/21 21:51:46 UTC
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12827
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Remove setting of 'kudu.master_addresses' from Kudu data loading
During dataload, for tables that don't have a CREATE_KUDU section in
their table definition (eg. in functional_schema_template.sql), we
automatically generate a CREATE TABLE statement that is appropriate
for a Kudu table (eg. we specify a primary key) to create the Kudu
version of the table.
Previously, we would also set the tblproperty 'kudu.master_addresses'.
This was required at the time, but we have since added the flag
--kudu_master_hosts, which provides a default value for this
tblproperty.
The expectation during data load is that there is only a single Kudu
service, the default that is passed in to --kudu_master_hosts, so it
is no longer necessary to specify 'kudu.master_addresses' during data
load.
Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
---
M testdata/bin/generate-schema-statements.py
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12827/1
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 04:55:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2511/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 22:24:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12827/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/12827/1/testdata/bin/generate-schema-statements.py@284
PS1, Line 284: row_format_stmt = str()
> This comment seems misleading now.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:34:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Remove setting of 'kudu.master_addresses' from Kudu data loading
During dataload, for tables that don't have a CREATE_KUDU section in
their table definition (eg. in functional_schema_template.sql), we
automatically generate a CREATE TABLE statement that is appropriate
for a Kudu table (eg. we specify a primary key) to create the Kudu
version of the table.
Previously, we would also set the tblproperty 'kudu.master_addresses'.
This was required at the time, but we have since added the flag
--kudu_master_hosts, which provides a default value for this
tblproperty.
The expectation during data load is that there is only a single Kudu
service, the default that is passed in to --kudu_master_hosts, so it
is no longer necessary to specify 'kudu.master_addresses' during data
load.
Testing:
- Ran a full data load and verified that the Kudu tables were loaded
as expected.
Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Reviewed-on: http://gerrit.cloudera.org:8080/12827
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/generate-schema-statements.py
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3942/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:24:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:06:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2514/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:18:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12827/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/12827/1/testdata/bin/generate-schema-statements.py@284
PS1, Line 284: # Fetch KUDU host and port from environment
This comment seems misleading now.
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 22:49:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 )
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:22:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12827
to look at the new patch set (#2).
Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading
......................................................................
Remove setting of 'kudu.master_addresses' from Kudu data loading
During dataload, for tables that don't have a CREATE_KUDU section in
their table definition (eg. in functional_schema_template.sql), we
automatically generate a CREATE TABLE statement that is appropriate
for a Kudu table (eg. we specify a primary key) to create the Kudu
version of the table.
Previously, we would also set the tblproperty 'kudu.master_addresses'.
This was required at the time, but we have since added the flag
--kudu_master_hosts, which provides a default value for this
tblproperty.
The expectation during data load is that there is only a single Kudu
service, the default that is passed in to --kudu_master_hosts, so it
is no longer necessary to specify 'kudu.master_addresses' during data
load.
Testing:
- Ran a full data load and verified that the Kudu tables were loaded
as expected.
Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
---
M testdata/bin/generate-schema-statements.py
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/12827/2
--
To view, visit http://gerrit.cloudera.org:8080/12827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id39c9f0679161ab3b31a188f4d41bb791cc2755c
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>