[jira] [Work logged] (CURATOR-654) DistributedBarrier watcher leak

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CURATOR-654?focusedWorklogId=817598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817598 ]

ASF GitHub Bot logged work on CURATOR-654:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Oct/22 12:56
            Start Date: 17/Oct/22 12:56
    Worklog Time Spent: 10m 
      Work Description: tisonkun commented on code in PR #435:
URL: https://github.com/apache/curator/pull/435#discussion_r997017352


##########
curator-recipes/src/main/java/org/apache/curator/framework/recipes/barriers/DistributedBarrier.java:
##########
@@ -92,6 +93,16 @@ public synchronized void      removeBarrier() throws Exception
         }
     }
 
+    /**
+     * Indicates if the barrier is set or not.
+     *
+     * @return true if the barrier is set.
+     */
+    public synchronized boolean     isSet() throws Exception

Review Comment:
   Annotated with `@VisibleForTesting`.





Issue Time Tracking
-------------------

            Worklog Id:     (was: 817598)
    Remaining Estimate: 0h
            Time Spent: 10m

> DistributedBarrier watcher leak
> -------------------------------
>
>                 Key: CURATOR-654
>                 URL: https://issues.apache.org/jira/browse/CURATOR-654
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 5.3.0
>            Reporter: Stuart Scott
>            Priority: Major
>         Attachments: CURATOR-654__Remove_watchers_after_waiting_for_barrier_.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The DistributedBarrier adds a zookeeper exists watcher in the waitOnBarrier() method. It appears as though the watcher is never removed. In a system where DistributedBarriers are used heavily this eventually results in the system running out of memory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)