svn commit: r1298410 - /myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java

[lu...@apache.org]

Author: lu4242
Date: Thu Mar  8 14:33:14 2012
New Revision: 1298410

URL: http://svn.apache.org/viewvc?rev=1298410&view=rev
Log:
MYFACES-3491 Unable to use direct char[] access of java.lang.String error on appengine

Modified:
    myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java

Modified: myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java?rev=1298410&r1=1298409&r2=1298410&view=diff
==============================================================================
--- myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java (original)
+++ myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StringCharArrayAccessor.java Thu Mar  8 14:33:14 2012
@@ -30,8 +30,8 @@ import java.lang.reflect.Field;
  *
  * java.lang.String creation reusing a char[] buffer requires Java 1.5+
  *
- * System property "stringchararrayaccessor.disabled" disables this hack.
- * -Dstringchararrayaccessor.disabled=true
+ * System property "oam.stringchararrayaccessor.enabled" enables this hack.
+ * -Doam.stringchararrayaccessor.enabled=true
  *
  * Read JSR-133, "9.1.1 Post-Construction Modification of Final Fields"
  * http://www.cs.umd.edu/~pugh/java/memoryModel/jsr133.pdf
@@ -44,8 +44,12 @@ import java.lang.reflect.Field;
 public class StringCharArrayAccessor
 {
 
-    static volatile boolean enabled = !Boolean
-            .getBoolean("oam.stringchararrayaccessor.disabled");
+    //static volatile boolean enabled = !Boolean
+    //        .getBoolean("oam.stringchararrayaccessor.disabled");
+    // In Google Application Engine this hack is not valid. We should
+    // set this one as default disabled.
+    static volatile boolean enabled = Boolean
+            .getBoolean("oam.stringchararrayaccessor.enabled");
 
     static Field valueField;
     static Field countField;